Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Julian Sikorski <belegdol@gmail.com>
To: Steve French <smfrench@gmail.com>, Jeremy Allison <jra@samba.org>
Cc: CIFS <linux-cifs@vger.kernel.org>
Subject: Re: Permission denied when chainbuilding packages with mock
Date: Sun, 7 Nov 2021 23:55:39 +0100	[thread overview]
Message-ID: <d4f3344a-5054-9f0c-11aa-e941a8b5c9c9@gmail.com> (raw)
In-Reply-To: <CAH2r5mvrPj5b460CeRT9+MNc1fOzwMixqsCN82v8KP_d+bgO2w@mail.gmail.com>

W dniu 07.11.2021 o 23:50, Steve French pisze:
> That is interesting ... and weird.   Why would POSIX allow doing
> something write related (fsync) without write permission?
> 
> To work around this (especially if the server is reliable enough) -
> simply mount with "nostrictsync" (we will write out cached writes to
> the server on flush, but won't send the fsync).
> 
> Will look at it more.

Mounting with nostrictsync has made the problem go away. Thank you both!

Best regards,
Julian

> 
> On Sun, Nov 7, 2021 at 4:47 PM Jeremy Allison <jra@samba.org> wrote:
>>
>> On Sun, Nov 07, 2021 at 11:15:49PM +0100, Julian Sikorski wrote:
>>> Hi,
>>>
>>> thanks for responding. I am using loglevel 10. I have uploaded the
>>> logs to my dropbox as they are too big to attach:
>>>
>>> https://www.dropbox.com/sh/r4b7q7ti2zmtlu9/AACqFY0FW2oW41Vu8l3nLZJSa?dl=0
>>>
>>> The problem happens around 15:45:48. Do the logs show what access mask
>>> the fsp is being opened with you requested?
>>> I am using quite an old samba server (4.9.5+dfsg-5+deb10u1) due to the
>>> fact that openmediavault is based off debian 10 and there are no samba
>>> backports available. Having said that, this configuration can work, as
>>> shown by goffice/goffice-0.10.50-1.fc35.src.rpm rebuild and the fact
>>> that it was working before for months previously.
>>
>> The error is occurring on the file:
>>
>> /srv/dev-disk-by-label-omv/julian/kernel/results/fedora-35-x86_64/goffice-0.10.50-2.fc35/goffice-devel-0.10.50-2.fc35.x86_64.rpm
>>
>> this is a regular file, not a directory
>> opened with ACCESS_MASK: 0x00120089
>>
>> that is:
>>
>> SEC_STD_SYNCHRONIZE|
>> SEC_STD_READ_CONTROL|
>> SEC_FILE_READ_ATTRIBUTE|
>> SEC_FILE_READ_EA|
>> SEC_FILE_READ_DATA
>>
>> so indeed, this is being opened *without*
>> SEC_FILE_WRITE_DATA|SEC_FILE_APPEND_DATA
>> so smbd is correct in returning ACCESS_DENIED
>> to an SMB2_FLUSH call.
>>
>> Looks like this is a client bug, in that it
>> is passing a Linux fsync(fd) call directly
>> to the SMB2 server without checking if the
>> underlying file is open for write access.
>>
>> In this case, the SMB2 client should just
>> return success to the caller, as any SMB_FLUSH
>> call will always return ACCESS_DENIED on a
>> non-writable file handle, and according to
>> Linux semantics calling fsync(fd) on an fd
>> open with O_RDNLY should return success.
>>
>> Steve, over to you :-).
>>
>> Jeremy.
> 
> 
> 


  reply	other threads:[~2021-11-07 22:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-07 21:10 Permission denied when chainbuilding packages with mock Julian Sikorski
2021-11-07 21:44 ` Jeremy Allison
2021-11-07 21:49   ` Jeremy Allison
2021-11-07 22:03     ` Jeremy Allison
2021-11-07 22:15     ` Julian Sikorski
2021-11-07 22:47       ` Jeremy Allison
2021-11-07 22:50         ` Steve French
2021-11-07 22:55           ` Julian Sikorski [this message]
2021-11-08  1:46           ` Jeremy Allison
2021-11-07 22:51         ` Julian Sikorski
2021-11-08  1:48           ` Jeremy Allison
2021-11-08  6:59             ` Julian Sikorski
2021-11-08 15:52               ` Julian Sikorski
2021-11-08 16:46               ` Jeremy Allison
2021-11-09  8:10                 ` Steve French
2021-11-09  9:26                   ` Julian Sikorski
2021-11-10  0:54                     ` Jeremy Allison
2021-11-10  7:56                       ` Steve French
2021-11-10 11:23                         ` Julian Sikorski
2021-11-13 15:37                           ` Julian Sikorski
2021-11-15  3:25                             ` Steve French
2021-11-15  7:10                               ` Julian Sikorski
2021-11-09 19:25                   ` Jeremy Allison
  -- strict thread matches above, loose matches on Subject: below --
2021-11-07 15:44 Julian Sikorski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4f3344a-5054-9f0c-11aa-e941a8b5c9c9@gmail.com \
    --to=belegdol@gmail.com \
    --cc=jra@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox