From: ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev>
To: David Howells <dhowells@redhat.com>,
Namjae Jeon <linkinjeon@kernel.org>,
Steve French <smfrench@gmail.com>,
Steve French <sfrench@samba.org>,
Namjae Jeon <linkinjeon@samba.org>
Cc: liuzhengyuan@kylinos.cn, huhai@kylinos.cn, liuyun01@kylinos.cn,
Paulo Alcantara <pc@manguebit.org>,
CIFS <linux-cifs@vger.kernel.org>,
ChenXiaoSong <chenxiaosong@kylinos.cn>
Subject: Re: [PATCH 2/2] cifs: Autogenerate SMB2 error mapping table
Date: Fri, 12 Dec 2025 18:19:51 +0800 [thread overview]
Message-ID: <d8768340-fc1f-440c-a2ed-92fbce332e60@linux.dev> (raw)
In-Reply-To: <811840.1765532505@warthog.procyon.org.uk>
Maybe we can merge the SMB1 and SMB2 error codes into a single header
file, but SMB1 seems to use fewer error codes. We should ask for Steve’s
and Namjae's opinions on this.
Thanks,
ChenXiaoSong.
On 12/12/25 5:41 PM, David Howells wrote:
> ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev> wrote:
>
>> Please see my minor suggestions and KUnit test results at this link:
>> https://chenxiaosong.com/en/smb-map-error.html
>
> Okay. Note it would be useful if you could reply to the email with minor
> suggestions so that they're archived along with the emails.
>
> Also note that the format we end up going with for smb2status.h is up for
> discussion. My preferred idea is something along the lines of:
>
> enum nt_status_codes {
> STATUS_SUCCESS = 0x00000000, // 0
> STATUS_WAIT_0 = STATUS_SUCCESS,
> STATUS_WAIT_1 = 0x00000001, // -EIO
> STATUS_WAIT_2 = 0x00000002, // -EIO
> STATUS_WAIT_3 = 0x00000003, // -EIO
> ...
> };
>
> and switching to using cpu-endian in the code.
>
> David
next prev parent reply other threads:[~2025-12-12 10:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 23:03 Can we autogenerate smb2_error_map_table[]? David Howells
2025-12-10 23:40 ` ChenXiaoSong
[not found] ` <CAH2r5msTSRvKRwQYjuVP62KB5beoS99e4eYKYHQ9ZPTYejykRA@mail.gmail.com>
2025-12-11 0:11 ` ChenXiaoSong
2025-12-11 15:03 ` [PATCH 1/2] cifs: Label SMB2 statuses with errors David Howells
2025-12-12 0:19 ` ChenXiaoSong
2025-12-12 0:29 ` ChenXiaoSong
2025-12-12 9:35 ` David Howells
2025-12-11 15:04 ` [PATCH 2/2] cifs: Autogenerate SMB2 error mapping table David Howells
2025-12-11 15:33 ` ChenXiaoSong
2025-12-11 15:43 ` David Howells
2025-12-12 2:09 ` ChenXiaoSong
2025-12-12 9:41 ` David Howells
2025-12-12 10:19 ` ChenXiaoSong [this message]
2025-12-12 9:48 ` David Howells
2025-12-11 15:11 ` Can we autogenerate smb2_error_map_table[]? David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8768340-fc1f-440c-a2ed-92fbce332e60@linux.dev \
--to=chenxiaosong.chenxiaosong@linux.dev \
--cc=chenxiaosong@kylinos.cn \
--cc=dhowells@redhat.com \
--cc=huhai@kylinos.cn \
--cc=linkinjeon@kernel.org \
--cc=linkinjeon@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=liuzhengyuan@kylinos.cn \
--cc=pc@manguebit.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).