Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Julian Sikorski <belegdol@gmail.com>
To: Steve French <smfrench@gmail.com>,
	CIFS <linux-cifs@vger.kernel.org>,
	samba-technical <samba-technical@lists.samba.org>
Cc: Paulo Alcantara <pc@cjr.nz>,
	Shyam Prasad N <nspmangalore@gmail.com>,
	"Stefan (metze) Metzmacher" <metze@samba.org>,
	Brian Caine <brian.d.caine@gmail.com>
Subject: Re: [PATCH][SMB3] workaround negprot bug in some Samba servers by changing order of negcontexts sent by Linux kernel client
Date: Wed, 13 Jul 2022 16:57:01 +0200	[thread overview]
Message-ID: <ed25591c-e62e-dcee-6df3-0530ef2ac555@gmail.com> (raw)
In-Reply-To: <CAH2r5mtuN-yswT5VTbNPzj02fwiHYOCe2eR8mcgRgRE8Qpkjgw@mail.gmail.com>

Am 12.07.22 um 07:34 schrieb Steve French:
> Starting with 5.18.8 (and 5.19-rc4) mount can now fail to older Samba
> servers due to a server bug handling padding at the end of the last
> negotiate context (negotiate contexts typically round up to 8 byte
> lengths by adding padding if needed). This server bug can be avoided
> by switching the order of negotiate contexts, placing a negotiate
> context at the end that does not require padding (prior to the recent
> netname context fix this was the case on the client).
> 
> Fixes: 73130a7b1ac9 ("smb3: fix empty netname context on secondary channels")
> 
> See attached fix to cifs.ko

This patch fixes the issue for me when applied on top of 5.18.11. Thanks!

Best regards,
Julian

Tested-by: Julian Sikorski <belegdol+github@gmail.com>

      parent reply	other threads:[~2022-07-13 14:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12  5:34 [PATCH][SMB3] workaround negprot bug in some Samba servers by changing order of negcontexts sent by Linux kernel client Steve French
2022-07-12  7:04 ` Shyam Prasad N
2022-07-13 14:57 ` Julian Sikorski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed25591c-e62e-dcee-6df3-0530ef2ac555@gmail.com \
    --to=belegdol@gmail.com \
    --cc=brian.d.caine@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=nspmangalore@gmail.com \
    --cc=pc@cjr.nz \
    --cc=samba-technical@lists.samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox