From: Tom Talpey <tom@talpey.com>
To: Steve French <smfrench@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>,
Shyam Prasad N <nspmangalore@gmail.com>
Subject: Re: [PATCH][SMB3 client] Server interface count incorrectly calculated
Date: Mon, 17 Oct 2022 17:28:50 -0400 [thread overview]
Message-ID: <ed5577b5-3fc2-cfac-8ea8-e8f425a47069@talpey.com> (raw)
In-Reply-To: <CAH2r5muH+n6TYS3_O9pbwREWJ_GYuva_PvOLd88pxG+t9kVeCA@mail.gmail.com>
On 10/17/2022 5:26 PM, Steve French wrote:
>
>
> On Mon, Oct 17, 2022, 16:03 Tom Talpey <tom@talpey.com
> <mailto:tom@talpey.com>> wrote:
>
> On 10/15/2022 6:10 PM, Steve French wrote:
> > smb3: interface count displayed incorrectly
> >
> > The "Server interfaces" count in /proc/fs/cifs/DebugData increases
> > as the interfaces are requeried, rather than being reset to the new
> > value. This could cause a problem if the server disabled
> > multichannel as the iface_count is checked in try_adding_channels
> > to see if multichannel still supported.
> >
> > Cc: <stable@vger.kernel.org <mailto:stable@vger.kernel.org>>
> >
> > See attached
> >
>
> This zeroes the ses->iface_count under the lock, but the whole
> routine is dropping and re-taking the same lock many times,
> and finally sets the iface_count without holding the lock at
> all.
>
>
> I updated the patch earlier today to fix that existing issue as well
> (served into same patch). If I missed something let me know
I was just looking at the patch attached to the message I replied to.
I'll look again, but it will have to be tomorrow.
Tom.
next prev parent reply other threads:[~2022-10-17 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 22:10 [PATCH][SMB3 client] Server interface count incorrectly calculated Steve French
2022-10-17 21:03 ` Tom Talpey
[not found] ` <CAH2r5muH+n6TYS3_O9pbwREWJ_GYuva_PvOLd88pxG+t9kVeCA@mail.gmail.com>
2022-10-17 21:28 ` Tom Talpey [this message]
[not found] ` <CAH2r5mvwy+foxWEznbD4R28=kv4-zdAqGwc7UTgH0WeCAceVEw@mail.gmail.com>
2022-10-20 5:47 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed5577b5-3fc2-cfac-8ea8-e8f425a47069@talpey.com \
--to=tom@talpey.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox