Re: [cocci] Improving source code parsing for “fs/smb/client/dir.c”?

[Markus Elfring <Markus.Elfring@web.de>]

> Thank you for the more understanable example.  I think it should ignore
> the code under the #else since parsing is not successful when that is
> taken into account. …

Improvable software behaviour can be demonstrated also with the following
source file example.


static int my_test_condition(void)
{
#ifdef MY_CONFIG_LEGACY_OPTION
    {
        /* Test comment */
    }
my_info:
 if (0)
    my_log("reminder!");
 else
    {
#else
    {
#endif
     my_log("test end");
    }
 return 0;
}


Questionable test result (according to the software combination “Coccinelle 1.3.0”):
Markus_Elfring@Sonne:…/Projekte/Coccinelle/Probe> /usr/bin/spatch --parse-c test-ifdef-legacy5.c
…
PB: not found closing brace in fuzzy parsing
ERROR-RECOV: found sync '}' at line 18
…
parse error 
 = File "test-ifdef-legacy5.c", line 19, column 0, charpos = 224
  around = '',
  whole content = 
badcount: 17
bad: static int my_test_condition(void)
…
bad:  return 0;
BAD:!!!!! }
…
nb good = 0,  nb passed = 3 =========> 15.00% passed
nb good = 0,  nb bad = 17 =========> 15.00% good or passed


How will the software evolution be continued?

Regards,
Markus