From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14985C433DF for ; Mon, 10 Aug 2020 17:06:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C846A2083B for ; Mon, 10 Aug 2020 17:06:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gXSEszn4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728054AbgHJRGd (ORCPT ); Mon, 10 Aug 2020 13:06:33 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:49176 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726720AbgHJRGb (ORCPT ); Mon, 10 Aug 2020 13:06:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597079190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bG1UX7UvzyL+s17qjFjJT/RaH5grYgUy2tkao7iejMk=; b=gXSEszn4R5yaE8Xi18eY28IJzTmzzo+mu7WpxUaGkNAcwTPdRIbitQGScLWhfbEY+yBVh8 bF/b235hZWziI0RSayhRF9QqQM6/tu7Y1gqh5JpjOC1BeeW4HGjuXfZqZqJt2U1yafpQu7 Dm/9XYxnG7S3ERO+V4v73q3rGs3QOic= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-mJfRyyPsM4u2vzX4vNf8kQ-1; Mon, 10 Aug 2020 13:06:28 -0400 X-MC-Unique: mJfRyyPsM4u2vzX4vNf8kQ-1 Received: by mail-qv1-f72.google.com with SMTP id f1so7678332qvx.13 for ; Mon, 10 Aug 2020 10:06:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=bG1UX7UvzyL+s17qjFjJT/RaH5grYgUy2tkao7iejMk=; b=Eh9WPjtwq9lENEaw8dr/9iZxZbxjeZDUK6xM03ad2u61/NjzZc74rMwJ9Re7/obVk0 BVjlWNrxe6f2rdk5WQqO2qlFDwkR7gz1d/FlWwiAxHyIKVUPkh2AwR7kpRcaXGHyoxkC Ngys4pcP0eRwt1+n3VErvPiWZQI/U90r0t3/ZE8q0/hKavxPkl7QUcii367WLfWznjR3 d0g75tEia397jjxjrjKEar9Na8JIofzIp98cIfHbe3PDMU4CA3/fFFDwsD0J/w1yehOl afu4se+HWrkiAV7gLNTiXnB5GTcvDEhUN+f9JKSlDHASdmBQ6gGm1QdVDClMW4gylTFE YV1Q== X-Gm-Message-State: AOAM5318rdMqvbHxhqEL/i4XZFqZugiNYDDXtNyUQXO5Dd6VJ8FWX+L8 da2/3QNqr2try1uaQnNRhCNLQSVZrGukZr2nua/7wWh9NS1pIJGFhiVyPyu5YlHG1OuK1hhA6X7 ULOfL9KmBDoCnclxqqGcWZw== X-Received: by 2002:ac8:4117:: with SMTP id q23mr29005607qtl.186.1597079188354; Mon, 10 Aug 2020 10:06:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlWfqS29REyKPSWZucycGqedyBlydewM4zc1ic5w6qlLsuinsxlRcAI6mVIAmH2h++AmLqgw== X-Received: by 2002:ac8:4117:: with SMTP id q23mr29005574qtl.186.1597079188107; Mon, 10 Aug 2020 10:06:28 -0700 (PDT) Received: from tleilax.poochiereds.net (68-20-15-154.lightspeed.rlghnc.sbcglobal.net. [68.20.15.154]) by smtp.gmail.com with ESMTPSA id l1sm15922877qtp.96.2020.08.10.10.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 10:06:27 -0700 (PDT) Message-ID: Subject: Re: [GIT PULL] fscache rewrite -- please drop for now From: Jeff Layton To: David Wysochanski , David Howells Cc: Steve French , Linus Torvalds , Alexander Viro , Matthew Wilcox , Christoph Hellwig , Trond Myklebust , Anna Schumaker , Steve French , Eric Van Hensbergen , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-nfs , CIFS , ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel , LKML Date: Mon, 10 Aug 2020 13:06:26 -0400 In-Reply-To: References: <447452.1596109876@warthog.procyon.org.uk> <1851200.1596472222@warthog.procyon.org.uk> <667820.1597072619@warthog.procyon.org.uk> <672169.1597074488@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4 (3.36.4-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Mon, 2020-08-10 at 12:35 -0400, David Wysochanski wrote: > On Mon, Aug 10, 2020 at 11:48 AM David Howells wrote: > > Steve French wrote: > > > > > cifs.ko also can set rsize quite small (even 1K for example, although > > > that will be more than 10x slower than the default 4MB so hopefully no > > > one is crazy enough to do that). > > > > You can set rsize < PAGE_SIZE? > > > > > I can't imagine an SMB3 server negotiating an rsize or wsize smaller than > > > 64K in today's world (and typical is 1MB to 8MB) but the user can specify a > > > much smaller rsize on mount. If 64K is an adequate minimum, we could change > > > the cifs mount option parsing to require a certain minimum rsize if fscache > > > is selected. > > > > I've borrowed the 256K granule size used by various AFS implementations for > > the moment. A 512-byte xattr can thus hold a bitmap covering 1G of file > > space. > > > > > > Is it possible to make the granule size configurable, then reject a > registration if the size is too small or not a power of 2? Then a > netfs using the API could try to set equal to rsize, and then error > out with a message if the registration was rejected. > ...or maybe we should just make fscache incompatible with an rsize that isn't an even multiple of 256k? You need to set mount options for both, typically, so it would be fairly trivial to check this at mount time, I'd think. -- Jeff Layton