From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Aur=C3=A9lien?= Aptel Subject: Re: [PATCH] CIFS: do not send invalid input buffer on QUERY_INFO requests Date: Wed, 18 Oct 2017 16:50:22 +0200 Message-ID: References: <20171017124717.25955-1-aaptel@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: Hadrien Grasland , linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-Reply-To: Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hadrien Grasland writes: > Just tried out this patch, and the CIFS module does indeed produce > well-formed GetInfo requests now (according to Wireshark's definition at > least, didn't check myself). > > However, the server will still reject the request with a > STATUS_NOT_SUPPORTED error, suggesting that Steve's interpretation was > the right one: this is likely a server-side bug. Yes. As Steve suggested as a workaround, we could try to use a less detailed information level if FullInfo fails. Is it worth doing for a single old NetApp server? As for the offset and extra byte in QUERY_INFO I guess having the length set to 0 makes it ok... I've sent a couple of patches to Wireshark to fix the packet parsing. It now accepts the empty filename in CREATE (no more "[unknown]"), which enables the proper parsing of the unknown field. -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)