From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9857C33439A for ; Wed, 17 Jun 2026 17:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781718489; cv=none; b=BdjCnr6pDpCAYmTLTITc5TMZ9o49dSfruyJdKDT6Qhlu6WLUo9DrjP6u9BrRHm+lU4jcqK2Gs62ktmZp0kCh0m4yX4aTNo9pMqmOFP6IGn9xIppC/rEl9Q92pGTJFpgvEC/NXI39K6brgWmA3L04ur25Xoa5lfohG4QReuNZCg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781718489; c=relaxed/simple; bh=BJu5zuBd984ABXNyYHw+39Dq7EX9ehyIzLRGUbQvlIY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=g8OsFDKchhdgiUBTLFMsaM5g2QTOkNeLM87hq/moSxN8TfSz6mCGPlMfenZhTK0R03QSbD7PUVYIiW9itvs1BYUFFmYgrHEM47izzoWZcC+y1STL6Ec2ATgHLLzYsIMvsD00mgm+h1K+8Yg8Bcgh3iomo+srpi8wlMcGxw9uvts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ce8BgISO; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ce8BgISO" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-46019edc13dso56457f8f.1 for ; Wed, 17 Jun 2026 10:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781718486; x=1782323286; darn=vger.kernel.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZR64uMa2bAG9g6xt9cb3u96jXreT/Fybs92ONnyRO6s=; b=ce8BgISO2hLPgURzL3RtgTefC72BDnZ4Vyu2da6ec+cvOSgartIgVjZY5KjyoxsxOd CL8nZsXrObMyNpkfnQEaXlHAX6x4RZ15TnCRWWCmSoHvSybjAAu+rr/KLeI4F3wDL/td lI46nATHr0nLdkdKjEszknVcQVzkw5vxo/L9hlyiMbQVP/XEmXdseEL+GgTpD4b/5cE3 3HS4FxPgGncvX/N8kbNBFtCWKl4RHqJi3pSXDBXj4eLhele7BG/8xq+Y3sZy9gndiOTg bb2NFbfOA625oZLhgAKsi3O6DOJsbvLWtAgIDanUk8D2tRPgiH/2AsHFS+VV7aR4vEB/ sk7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781718486; x=1782323286; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZR64uMa2bAG9g6xt9cb3u96jXreT/Fybs92ONnyRO6s=; b=GGZfNV+wrqUxqdiyyeSU3g18zPD5m7iAqCxVc/co8Tu08xdaK9KvKqb94q6lMc0EKM fw9jIfobv6l6LLGbmO1ApHgQORIRy/Kno0+6c0Zy15nBwS1YUFcmaJiPoTNYd8HEqniI hdnyHt46bBZcTTgNoYGmYgxHsyMEehVMwp11oUZuGCR5tx0aDRupVIAm0N/v0T3pmFtQ dEo4qbN+G54QvwT1fMLOP7Q+Qby24zjtSH0uoJSJAowiMOTgNEPrX7Mpd/6/6mBSKVme d3PhnHUgmjaxHBgMueXBZZoCA4em7kJtKv9/ke0PWAveHZi9tOXDZh+BkDwy6cxrwMJM E9AQ== X-Forwarded-Encrypted: i=1; AFNElJ8iBA/OCOswNZTh/yODZtg4HrEry7gDQkU9D7rOZo01Wb4nlInCQWJ2zsT7Og8+Jb13s8j4mtjVF8A=@vger.kernel.org X-Gm-Message-State: AOJu0YyDksTV4HhnRPvYAC1njZTnxEiSDrhESU7l3IucTuAueBzWLLAF WQt1pJ7VRhZbzs4ngCiELvl0SGMh0TCljoTzhgAMLJDQG2HO+ZFuz8pl X-Gm-Gg: AfdE7clpQUq10GvZ3e5PewXwEB4v//0kSB3f1JWZZUcbZW+ann+uiS8u6wiN7l7l9Qj jPdTDms5LPMVtNhx83CgF/BZusIrWqt/XlSqnEWIAaI2rdD1bTe0bfjdD8INq5mkO8JtTxSubC4 qObXTRwRtpo0/JvJhBGvedT5JEwfGQ+HcVjZOn6jcptkNKvyfG0Tn3Pnr04gZKrhgalBFpNcm3E Yd39rx/LMsdJAU+NpFtKndS6+HAZVp5RVKbOBHTiWG4XbTiHzZ3DwbrYzkNoazQbLIrL3RDKLTh L88RB2TOocy8TsNdrDhFl+sKMVDeEBvMEwByRsXNMq/9XOBOAxhPmmqFtUhDJei+2XS1MFQvMr/ FSwvyubel1tTDhnXvSHQB3+t4aiiMCL4BonMBjGoUE35/1qHc+kyNsLp5Eyvfln02OX1ezP2Nhy dLrKJgE8iSb5eg9j6Z33pABfLa+Q== X-Received: by 2002:a05:6000:1789:b0:446:db72:e8ec with SMTP id ffacd0b85a97d-46240cf95d5mr8421507f8f.23.1781718485787; Wed, 17 Jun 2026 10:48:05 -0700 (PDT) Received: from strix.localnet ([197.250.227.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f263945sm57712415f8f.8.2026.06.17.10.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 10:48:04 -0700 (PDT) From: Stefan =?UTF-8?B?RMO2c2luZ2Vy?= To: Conor Dooley Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Brian Masney , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFC v4 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset bindings Date: Wed, 17 Jun 2026 20:47:53 +0300 Message-ID: <-l2OM6P0RNSYRQfOSObOyw@gmail.com> In-Reply-To: <20260617-tabasco-pulsate-454ed3f8f0b6@spud> References: <20260616-zx29clk-v4-0-ca994bd22e9d@gmail.com> <20260616-zx29clk-v4-1-ca994bd22e9d@gmail.com> <20260617-tabasco-pulsate-454ed3f8f0b6@spud> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPartJBti3yevQCyGA81fgJgUkw"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextPartJBti3yevQCyGA81fgJgUkw Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Stefan =?UTF-8?B?RMO2c2luZ2Vy?= To: Conor Dooley Date: Wed, 17 Jun 2026 20:47:53 +0300 Message-ID: <-l2OM6P0RNSYRQfOSObOyw@gmail.com> In-Reply-To: <20260617-tabasco-pulsate-454ed3f8f0b6@spud> MIME-Version: 1.0 Am Mittwoch, 17. Juni 2026, 19:08:02 Ostafrikanische Zeit schrieb Conor=20 Dooley: > On Tue, Jun 16, 2026 at 11:26:21PM +0300, Stefan D=C3=B6singer wrote: > > +F: Documentation/devicetree/zte,zx297520v3-* >=20 > Sashiko complaint here looks valid. Yes, it is valid. It also brought up another concern in patch 12 that has an impact on this=20 binding: Am Dienstag, 16. Juni 2026, 23:42:19 Ostafrikanische Zeit schrieb sashiko- bot@kernel.org: > issue(s) to consider: - [Low] The `syscon-reboot` node is incorrectly > defined at the root level using the explicitly deprecated `regmap` > property. -- And indeed "regmap" is deprecated and I missed it somehow. As far as I=20 understand, to put syscon-reboot as a child of the clock, I need to add the= =20 simple-mfd .compatible: Either topclk: clock-controller@13b000 { compatible =3D "zte,zx297520v3-topclk", "syscon", "simple-mfd"; reg =3D <0x0013b000 0x400>; ... syscon-reboot { compatible =3D "syscon-reboot"; regmap =3D <&topclk>; offset =3D <0x0>; mask =3D <0x1>; }; }; =2D-- or --- something@13b000 { compatible =3D "zte,zx297520v3-topcrm", "syscon", "simple-mfd"; reg =3D <0x0013b000 0x400>; ranges; topclk: clock-controller@0 { compatible =3D "zte,zx297520v3-topclk"; ... } syscon-reboot { compatible =3D "syscon-reboot"; offset =3D <0x0>; mask =3D <0x1>; }; }; I see both ways in existing DTS files (e.g. imx6sl.dtsi for the fomer,=20 uniphier-pro4.dtsi for the latter). Is there a preferred way? I have a mild= =20 preference for the first, as it would keep all 3 clocks in the same way. If= I=20 go for the second, the clock driver would have to query its own node and th= e=20 parent node for the regmap. AFAIU unrelated to syscon-reboot option 2 would give me the opportunity to= =20 have separate clock and reset nodes and bindings and skip the aux bus, but= =20 this would not be a correct representation of how the hardware works. --nextPartJBti3yevQCyGA81fgJgUkw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQJPBAABCAA5FiEEQxb0tqoFWyeVMl1sPRO8yFRPGiIFAmoy3ckbFIAAAAAABAAO bWFudTIsMi41KzEuMTIsMiwyAAoJED0TvMhUTxoiYhsQAIShhN0EMMLivsL4YTkw 5v1LXpB2e5pyTGJADq4zJ7jpoL5M5U66D/blUzW3M2QmTsbt5PpE2QrKp/mgImGI TM3prev1qjMzHYov/LErP4wEcvShHPacjc3h2AFslmfJslU4iLOplzaHqxoJ2C4O SqK8M6h9ggZofVn5f9ykwFu3/3OTWOrQD/vLO4PffYZPFzZn8d4j8gnUxDVio9yY L9iVGedu8gvqMSCT2RGVeVsKFdXefaJXR7noAWvjyDusgzpiQX0HRYy8zEYcDcl9 sp0vGFq4lKNQlwkR5a1cU71m5HVegyq7E6BqC4zxVSCe7AcV2B/xYu5bRz7+fwi6 WEKdaafl8XvxtchAQyAG8prLZ722Fc1iNzE/Aa9adZBJA8BtxmNj/0Q1DmKT1cEe 0vjDwsN1brxvOuIoadocDxhfcD8CjBmDuUl+P9EPBzrOMicZchr7rlELZ/gTjqy1 fRebnrPsjspoc8LsvXPnuzNvVhxDIS69w7rQd74yu03SsMDzuJsYc39oYAuYWTpk BcgrjlfMuiPDmGGnHEgUMtJDmzbyy9nfoiZXHpbD+V7KbD0Yv8hLdvjFbGaDDP9z HOLdkQt4SKBTG4pAGym5UR5ztF2bvTSVAJedmacdn0dhkx7GcPu9hR5fvQMsbgQt nf+USg3fU6CKa5Ynka2KN3Cx =mLYQ -----END PGP SIGNATURE----- --nextPartJBti3yevQCyGA81fgJgUkw--