Linux clock framework development
 help / color / mirror / Atom feed
From: Alexandre Torgue <alexandre.torgue@st.com>
To: <gabriel.fernandez@st.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	benjamin GAIGNARD <benjamin.gaignard@st.com>,
	Loic PALLARDY <loic.pallardy@st.com>
Subject: Re: [RESEND PATCH] clk: stm32: fix: stm32 clock drivers are not compiled by default
Date: Fri, 4 May 2018 09:54:16 +0200	[thread overview]
Message-ID: <0066b4db-8da6-007d-780d-a8ffc4884ad0@st.com> (raw)
In-Reply-To: <1525329609-7291-1-git-send-email-gabriel.fernandez@st.com>

Stephen

On 05/03/2018 08:40 AM, gabriel.fernandez@st.com wrote:
> From: Gabriel Fernandez <gabriel.fernandez@st.com>
> 
> Clock driver is mandatory if the machine is selected.
> Then don't use 'bool' and 'depends on' commands, but 'def_bool'
> with the machine(s).
> 
> Fixes: da32d3539fca ("clk: stm32: add configuration flags for each of the stm32 drivers")
> 

Sorry to insist but we need it to have STM32 MCUs booting on Kernel v4.17.

Thanks in advance
Alex

> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com>
> Acked-by: Alexandre TORGUE <alexandre.torgue@st.com>
> ---
>   drivers/clk/Kconfig | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 24a5bc3..721572a 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -266,15 +266,13 @@ config COMMON_CLK_STM32MP157
>   	  Support for stm32mp157 SoC family clocks
>   
>   config COMMON_CLK_STM32F
> -	bool "Clock driver for stm32f4 and stm32f7 SoC families"
> -	depends on MACH_STM32F429 || MACH_STM32F469 || MACH_STM32F746
> +	def_bool COMMON_CLK && (MACH_STM32F429 || MACH_STM32F469 || MACH_STM32F746)
>   	help
>   	---help---
>   	  Support for stm32f4 and stm32f7 SoC families clocks
>   
>   config COMMON_CLK_STM32H7
> -	bool "Clock driver for stm32h7 SoC family"
> -	depends on MACH_STM32H743
> +	def_bool COMMON_CLK && MACH_STM32H743
>   	help
>   	---help---
>   	  Support for stm32h7 SoC family clocks
> 

  reply	other threads:[~2018-05-04  7:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03  6:40 [RESEND PATCH] clk: stm32: fix: stm32 clock drivers are not compiled by default gabriel.fernandez
2018-05-04  7:54 ` Alexandre Torgue [this message]
2018-05-05  2:45   ` Stephen Boyd
2018-05-14 12:45     ` Alexandre Torgue
2018-05-15 21:48       ` Stephen Boyd
2018-05-16  7:34         ` Alexandre Torgue
2018-05-16  7:57           ` Stephen Boyd
2018-05-16  8:01             ` Alexandre Torgue
2018-05-16  7:58 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0066b4db-8da6-007d-780d-a8ffc4884ad0@st.com \
    --to=alexandre.torgue@st.com \
    --cc=benjamin.gaignard@st.com \
    --cc=gabriel.fernandez@st.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.pallardy@st.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox