Re: [PATCH 2/3] clk: samsung: exynosautov920: add peric1, misc and hsi0/1 clock support

Krzysztof Kozlowski
2024-10-07T08:06:57Z

On 07/10/2024 10:04, sunyeal.hong wrote:
> Hello Krzysztof,
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Monday, September 30, 2024 8:36 PM
>> To: Sunyeal Hong <sunyeal.hong@samsung.com>; Krzysztof Kozlowski
>> <krzk+dt@kernel.org>; Rob Herring <robh@kernel.org>; Conor Dooley
>> <conor+dt@kernel.org>; Alim Akhtar <alim.akhtar@samsung.com>; Sylwester
>> Nawrocki <s.nawrocki@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>;
>> Michael Turquette <mturquette@baylibre.com>; Stephen Boyd
>> <sboyd@kernel.org>
>> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
>> linux-samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
>> clk@vger.kernel.org
>> Subject: Re: [PATCH 2/3] clk: samsung: exynosautov920: add peric1, misc
>> and hsi0/1 clock support
>>
>> On 12/09/2024 12:38, Sunyeal Hong wrote:
>>> Like CMU_PERIC1, this provides clocks for USI09 ~ USI17, USI_I2C and
>> USI_I3C.
>>> Like CMU_MISC, this provides clocks for MISC, GIC and OTP.
>>> Like CMU_HSI0, this provides clocks for PCIE.
>>> Like CMU_HSI1, this provides clocks for USB and MMC.
>>>
>>> Signed-off-by: Sunyeal Hong <sunyeal.hong@samsung.com>
>>> ---
>>
>> ...
>>
>>> +
>>> static int __init exynosautov920_cmu_probe(struct platform_device
>>> *pdev) {
>>> const struct samsung_cmu_info *info; @@ -1154,6 +1431,19 @@ static
>>> const struct of_device_id exynosautov920_cmu_of_match[] = {
>>> {
>>> .compatible = "samsung,exynosautov920-cmu-peric0",
>>> .data = &peric0_cmu_info,
>>> + }, {
>>> + .compatible = "samsung,exynosautov920-cmu-peric1",
>>> + .data = &peric1_cmu_info,
>>> + }, {
>>> + .compatible = "samsung,exynosautov920-cmu-misc",
>>> + .data = &misc_cmu_info,
>>> + }, {
>>> + .compatible = "samsung,exynosautov920-cmu-hsi0",
>>> + .data = &hsi0_cmu_info,
>>> + }, {
>>> + .compatible = "samsung,exynosautov920-cmu-hsi1",
>>> + .data = &hsi1_cmu_info,
>>> + }, {
>>
>> This is unrelated change. Please rebase.
>>
> Could you please explain in more detail the comment mentioned above?

You were growing this list, didn't you? Then adding sentinel is unrelated.

Best regards,
Krzysztof