From: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
linux-actions@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] dt-bindings: clock: actions,owl-cmu: convert to YAML
Date: Mon, 4 Nov 2024 22:19:57 +0200 [thread overview]
Message-ID: <0198082e-19a2-48e8-ada1-a7edaeddb73c@gmail.com> (raw)
In-Reply-To: <20241104-lend-lark-ab46a268213a@spud>
On 11/4/24 21:03, Conor Dooley wrote:
> On Mon, Nov 04, 2024 at 05:31:08PM +0200, Ivaylo Ivanov wrote:
>> + soc {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
> FWIW, you could drop these two if...
I see, although the point of this was to keep it the example as close
to the original usage in s900.dtsi as possible. Anyways, if a v2 is
needed, I can do that.
Thanks for the review!
Best regards, Ivo.
>
>> + cmu: clock-controller@e0160000 {
>> + compatible = "actions,s900-cmu";
>> + reg = <0x0 0xe0160000 0x0 0x1000>;
> ...you dropped the 0x0s from here.
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Cheers,
> Conor.
next prev parent reply other threads:[~2024-11-04 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 15:31 [PATCH v1] dt-bindings: clock: actions,owl-cmu: convert to YAML Ivaylo Ivanov
2024-11-04 19:03 ` Conor Dooley
2024-11-04 20:19 ` Ivaylo Ivanov [this message]
2024-11-06 1:02 ` Stephen Boyd
2024-11-06 1:03 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0198082e-19a2-48e8-ada1-a7edaeddb73c@gmail.com \
--to=ivo.ivanov.ivanov1@gmail.com \
--cc=afaerber@suse.de \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox