From: Marek Vasut <marek.vasut@mailbox.org>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: linux-clk@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] clk: renesas: cpg-mssr: Add missing 1ms delay into reset toggle callback
Date: Mon, 6 Oct 2025 01:40:56 +0200 [thread overview]
Message-ID: <01fa4d9b-2ef2-4410-a690-35a28591ccda@mailbox.org> (raw)
In-Reply-To: <20251005134220.GA1015803@ragnatech.se>
On 10/5/25 3:42 PM, Niklas Söderlund wrote:
Hello Niklas,
>> I do wonder, would it be better if risp used reset_assert()/reset_deassert()
>> when performing reset in atomic context ? Also, why is it even performing
>> reset in atomic context ?
>
> The ISP driver needs to serialize a set of buffer queues when it want to
> consume from them. This happens at two locations, start and interrupt
> context.
>
> As this was not an issue before a spinlock have been used to marshal
> this. However at start time, as the spinlock is taken anyhow, it have
> also been used to protect against multiple starts that would call reset.
Now that I actually looked at that driver, I understand, thank you for
pointing me to it.
next prev parent reply other threads:[~2025-10-05 23:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 3:04 [PATCH] clk: renesas: cpg-mssr: Add missing 1ms delay into reset toggle callback Marek Vasut
2025-09-22 11:37 ` Geert Uytterhoeven
2025-09-22 14:53 ` Marek Vasut
2025-09-30 12:24 ` Geert Uytterhoeven
2025-10-03 15:08 ` Niklas Söderlund
2025-10-05 4:00 ` Marek Vasut
2025-10-05 7:12 ` Niklas Söderlund
2025-10-05 13:17 ` Marek Vasut
2025-10-05 13:42 ` Niklas Söderlund
2025-10-05 23:40 ` Marek Vasut [this message]
2025-10-06 11:53 ` Geert Uytterhoeven
2025-10-06 12:23 ` Niklas Söderlund
2025-10-09 18:12 ` Niklas Söderlund
2025-10-10 7:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01fa4d9b-2ef2-4410-a690-35a28591ccda@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox