From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jerome Brunet" <jbrunet@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>
Cc: "Neil Armstrong" <neil.armstrong@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Mark Brown" <broonie@kernel.org>
Subject: Re: [PATCH] clk: amlogic: axg-audio: select RESET_MESON_AUX
Date: Wed, 04 Dec 2024 21:10:24 +0100 [thread overview]
Message-ID: <0241900c-3533-42d1-8dc0-df64181e6aca@app.fastmail.com> (raw)
In-Reply-To: <1jfrn3l615.fsf@starbuckisacylon.baylibre.com>
On Wed, Dec 4, 2024, at 18:19, Jerome Brunet wrote:
> On Tue 03 Dec 2024 at 12:15, Stephen Boyd <sboyd@kernel.org> wrote:
>>>
>>> May I add back the boiler plate code in drivers/clk/meson, similar to
>>> what was proposed in the RFC [1] and propose the generic implementation
>>> in parallel ? It will just be a matter of switching when/if it is approved.
>>
>> Sure. You can make devm_meson_clk_rst_aux_register() use the same
>> signature as I proposed above so that it's a one line patch later. And
>> definitely drop the imply RESET_MESON and depends on REGMAP part. Maybe
>> you can put it in the clkc-utils file?
> * Why drop 'imply RESET_MESON_AUX' ? I would still like the
> COMMON_CLK_AXG_AUDIO to 'strongly suggest' RESET_MESON_AUX, with
> dependency problem sorted out.
You can do it the other way round and use 'default
COMMON_CLK_AXG_AUDIO' if you want to tie the two together
with the same effect but avoid the ugly "imply" statement.
I still think it's best to just leave it out. From a user
perspective, the dependency isn't really that the clk
driver needs the reset driver, but instead it's the audio
driver that needs both.
Arnd
next prev parent reply other threads:[~2024-12-04 20:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 18:47 [PATCH] clk: amlogic: axg-audio: select RESET_MESON_AUX Jerome Brunet
2024-11-27 19:00 ` Mark Brown
2024-11-27 19:30 ` Arnd Bergmann
2024-11-27 20:56 ` Jerome Brunet
2024-11-27 21:23 ` Arnd Bergmann
2024-11-28 13:33 ` Jerome Brunet
2024-11-28 14:11 ` Arnd Bergmann
2024-11-28 14:39 ` Jerome Brunet
2024-11-28 14:51 ` Arnd Bergmann
2024-11-28 15:06 ` Jerome Brunet
2024-11-28 15:34 ` Arnd Bergmann
2024-11-28 15:52 ` Mark Brown
2024-11-28 15:57 ` Arnd Bergmann
2024-11-28 16:02 ` Jerome Brunet
2024-11-28 15:53 ` Jerome Brunet
2024-11-28 17:21 ` Arnd Bergmann
2024-12-03 2:53 ` Stephen Boyd
2024-12-03 11:15 ` Jerome Brunet
2024-12-03 20:15 ` Stephen Boyd
2024-12-03 22:22 ` Mark Brown
2024-12-03 22:32 ` Stephen Boyd
2024-12-03 22:59 ` Mark Brown
2024-12-04 17:19 ` Jerome Brunet
2024-12-04 20:05 ` Stephen Boyd
2024-12-04 20:10 ` Arnd Bergmann [this message]
2024-12-03 12:43 ` Arnd Bergmann
2024-12-03 20:21 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0241900c-3533-42d1-8dc0-df64181e6aca@app.fastmail.com \
--to=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox