Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver

Hans Verkuil
2020-04-25T09:36:32Z

On 24/04/2020 17:11, Dmitry Osipenko wrote:
> 24.04.2020 06:55, Sowjanya Komatineni пишет:
>> Tegra210 contains a powerful Video Input (VI) hardware controller
>> which can support up to 6 MIPI CSI camera sensors.
>>
>> Each Tegra CSI port can be one-to-one mapped to VI channel and can
>> capture from an external camera sensor connected to CSI or from
>> built-in test pattern generator.
>>
>> Tegra210 supports built-in test pattern generator from CSI to VI.
>>
>> This patch adds a v4l2 capture driver with media interface for
>> Tegra210 built-in CSI to VI test pattern generator.
>>
>> This patch includes TPG support only and all the video pipeline
>> configuration happens through the video device node.
>>
>> Acked-by: Thierry Reding <treding@nvidia.com>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>> drivers/staging/media/Kconfig | 2 +
>> drivers/staging/media/Makefile | 1 +
>> drivers/staging/media/tegra/Kconfig | 12 +
>> drivers/staging/media/tegra/Makefile | 8 +
>> drivers/staging/media/tegra/TODO | 10 +
>> drivers/staging/media/tegra/common.h | 259 ++++++++
>> drivers/staging/media/tegra/csi.c | 604 +++++++++++++++++
>> drivers/staging/media/tegra/csi.h | 144 ++++
>> drivers/staging/media/tegra/tegra210.c | 708 ++++++++++++++++++++
>> drivers/staging/media/tegra/tegra210.h | 190 ++++++
>> drivers/staging/media/tegra/vi.c | 1127 ++++++++++++++++++++++++++++++++
>> drivers/staging/media/tegra/vi.h | 72 ++
>> drivers/staging/media/tegra/video.c | 153 +++++
>> drivers/staging/media/tegra/video.h | 29 +
>
> The media/tegra/ sounds a bit too generic, the media/tegra-vi/ path
> should better reflect the driver, IMO.
>
> It also should be better to name the compiled kernel module as tegra-vi,
> IMO.
>

The driver name and the directory should be in sync, so either tegra-video
or tegra-vi for both. I have no preference myself, as long as they are the
same.

This can be done as a follow-up patch.

Regards,

Hans