From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57284CCA47B for ; Fri, 10 Jun 2022 09:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347121AbiFJJuJ (ORCPT ); Fri, 10 Jun 2022 05:50:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346721AbiFJJuH (ORCPT ); Fri, 10 Jun 2022 05:50:07 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 485796EC4B for ; Fri, 10 Jun 2022 02:50:01 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id d14so8984357eda.12 for ; Fri, 10 Jun 2022 02:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Rt0vsBETdsgUvTDEEF7Ic9okr/eCyvwvGWQNcegTZ1U=; b=K/yzPSh9wFBjDJiOA6mpuNoAmJIKYwK3g8Env7ES4l8idYzYh5vHjgqeOxkl5OR6bn IMj7pH0hNN2Hbo7fdFYujHzzlaDKoaPPfHTj7ois4W2c1KFVLn0j1kc8kPreMz+fwBD2 8Y7cGMwLibjZGW9UUAyX77himHkESzcNGvtnAlQuUpORd6vmIxb5pD+jpchqbs8DPaIj QJpE1T69z+wZwgdXiAnaQrf79KtOQD3foIrBEiB1NjabSUmVvNpTXF/nBck0nNsBEuBA 7BUPkg6E92dCrSV3VCVSZUnCfAbpDLrtjYK2KcdxC1RkfdaaJ1EXR9xblSWsZT6vQHQW b6Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Rt0vsBETdsgUvTDEEF7Ic9okr/eCyvwvGWQNcegTZ1U=; b=CzS4dB0W9czILxoNEgzEX7Ef9PNnorMnfK72Mas3YOqdvMRvyfSCkLQbiieeRweojV rECrl/isBF/oOKGlCEVl0pIUv6U5mYIegnPVeoGqM1M+l+PsVeN7ps+P0Rh8C0kP1Iv2 xdfOLA7WwU1SNy90kfgevekW5uWVaMEVdpEQVfJxyG4JTksPfICeH3il/BVTS6zmd8eD StwhKjfCeh8mwDpIEvphVZteKR2J9bW1eTir6FXhMQsnrUomvCAcLKQs6N+MeHzsMLfU JcLFt74vxrMG8CpkOXRLbZA4y1SguadGdWZfyRm4/kbdcEjD2lQ9sosjxnxekOLUmHVJ 6F0Q== X-Gm-Message-State: AOAM533GUO9NtyCilejBA4p5X7fpGb6nT1nnMU/K+3OAC1xJIubAUgHr fSGZXTwERPLscupdzzfYVmvw+A== X-Google-Smtp-Source: ABdhPJwbncSEwRQLaREXRi0rWknK/es2MLMTWpIk6/6WsQooAUY1QVyYSs0C9HIhLSoLy3pXr+xjPQ== X-Received: by 2002:a05:6402:3551:b0:431:51e1:856f with SMTP id f17-20020a056402355100b0043151e1856fmr30811673edd.323.1654854599932; Fri, 10 Jun 2022 02:49:59 -0700 (PDT) Received: from [192.168.0.201] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id yz17-20020a170906dc5100b0070b1ecdc12bsm10807528ejb.112.2022.06.10.02.49.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 02:49:59 -0700 (PDT) Message-ID: <073fcd16-12ae-ed4f-5eac-534bf73e68fe@linaro.org> Date: Fri, 10 Jun 2022 11:49:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 06/20] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock Content-Language: en-US To: Tomer Maimon Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , Robert Hancock , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Lubomir Rintel , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-7-tmaimon77@gmail.com> <082366b0-6811-b492-c68c-12f9a9ee512e@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 09/06/2022 23:21, Tomer Maimon wrote: > Hi Krzysztof, > > > On Thu, 9 Jun 2022 at 16:22, Krzysztof Kozlowski > wrote: >> >> On 09/06/2022 15:17, Tomer Maimon wrote: >>> Hi Krzysztof, >>> >>> Thanks for your comments. >>> >>> On Wed, 8 Jun 2022 at 13:03, Krzysztof Kozlowski >>> wrote: >>>> >>>> On 08/06/2022 11:56, Tomer Maimon wrote: >>>>> Add binding for the Arbel BMC NPCM8XX Clock controller. >>>>> >>>>> Signed-off-by: Tomer Maimon >>>>> --- >>>>> .../bindings/clock/nuvoton,npcm845-clk.yaml | 63 +++++++++++++++++++ >>>>> .../dt-bindings/clock/nuvoton,npcm8xx-clock.h | 50 +++++++++++++++ >>>>> 2 files changed, 113 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml >>>>> create mode 100644 include/dt-bindings/clock/nuvoton,npcm8xx-clock.h >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml >>>>> new file mode 100644 >>>>> index 000000000000..e1f375716bc5 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml >>>>> @@ -0,0 +1,63 @@ >>>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: Nuvoton NPCM8XX Clock Controller Binding >>>>> + >>>>> +maintainers: >>>>> + - Tomer Maimon >>>>> + >>>>> +description: | >>>>> + Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller, which >>>>> + generates and supplies clocks to all modules within the BMC. >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - nuvoton,npcm845-clk >>>>> + >>>>> + reg: >>>>> + maxItems: 1 >>>>> + >>>>> + clocks: >>>>> + items: >>>>> + - description: 25M reference clock >>>>> + - description: CPU reference clock >>>>> + - description: MC reference clock >>>>> + >>>>> + clock-names: >>>>> + items: >>>>> + - const: refclk >>>>> + - const: sysbypck >>>>> + - const: mcbypck >>>>> + >>>> >>>> I asked what is the suffix about and you replied "ck"... ok, so let's >>>> make clear. This should be: >>>> >>>> items: >>>> - const: ref >>>> - const: sysbyp >>>> - const: mcbyp >>>> >>>> or something similar, without the same suffix all over. >>> The clock names are the same clock name in our spec, this why we >>> prefer to leave the clock names as is. >> >> The naming with useless suffixes does not help. If your spec had >> "refclk_really_clock_this_is_a_clock" you also would insist on that? It >> does not make sense. > Sorry but I don't understand why the clock name cause an issue, we > prefer it will be the same as in our spec-clock diagram > BTW, the same naming found in NPCM7XX > https://elixir.bootlin.com/linux/v5.19-rc1/source/Documentation/devicetree/bindings/clock/nuvoton,npcm750-clk.txt#L36 Because the names should not have irrelevant information. interrupt-names should have "txirq". dma-names should not have "txdma". clock-names should not have "refclock" or "refclk" because it is irrelevant duplication. These are bindings, not DTS, so whatever you have in your spec matters less. DTS is the representation of hardware and there you can name clocks closer to the spec so it is easier for you, if that's your preference. And if your spec has "refclk_really_clock_this_is_a_clock" you still should not use it. Anyway, you should discuss it last time when I pointed it out. Instead my comments were ignored and you decided to send v2. That's not how discussion works and it will not bring you closer to your point. Best regards, Krzysztof