From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E0352512D6; Wed, 5 Mar 2025 20:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741205653; cv=none; b=uPzeJoeSh3/O8hQcnwtFxWDCqQJV0qLF1Urh4lpESauQrGBNTR+e9/bYcrxtHTb1uwH54bFr7zwcrj0LQi4vgAXhs/Hs+acIfrNCB+q5Qg288NOmJ1BYlozMjHC/8SnMGGAWsUJMTUSyXgYpJCplke2eusT7gcSUXt35hW9NfH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741205653; c=relaxed/simple; bh=HDnrB4nEnljM8RGpjYJcqggNGEbrKzMXtNEH2FuUmSM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ekOVbpLS9SUs/ZHqySAnDqG1LYjOPdFj0FZaaOYNiLnnL/gQyGWyRszSVUu5EpspDvHGZRb+I+/FiWZsEw7PZzI2RfUAqQMsXdW+xTdPYzgYkNI5OwkOfY64zURl9xXniRsX/EFJf8P4amPz2d45EfIfyObWZfRFwBWvZS4psY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=inZG2VL+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="inZG2VL+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2849DC4CED1; Wed, 5 Mar 2025 20:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741205652; bh=HDnrB4nEnljM8RGpjYJcqggNGEbrKzMXtNEH2FuUmSM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=inZG2VL+HEY0d4yHQnh74ltWdDsiF+gOqXcWQ34MYzDzKaBOw7LFCu0UjqXIZ86h8 eyQC/D0G6UxHScdilRnK6UWsQ08YINESdXUdgEWiEFMfCFt+MZGy7HTidEDsJoeCwR Y5u8yX+NhmmQImlN5HmUX66ewdI8rBL719CLwqilWsK1ANjW289nMgTzGBHO9Ep0iT 6qQjR0FY/UUrXsSuGbxqQYIgwBwHEehwYCYs5LoKK9ZX/EyAL7IqczVrtTvnHjxHS5 XNKvhdyfoWJbhA+sVpT2ll6ns4/QuwZ67WpHvQxFFZD/5JYBiv1BYjF2uujsBZ1Vq3 xQ9WM+NNoO9rg== Message-ID: <0a7c72cb-4b59-4146-8438-52d13b457a18@kernel.org> Date: Wed, 5 Mar 2025 21:14:05 +0100 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] clk: samsung: add initial exynos7870 clock driver To: Stephen Boyd , Alim Akhtar , Chanwoo Choi , Conor Dooley , Kaustabh Chakraborty , Michael Turquette , Rob Herring , Sylwester Nawrocki Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250301-exynos7870-pmu-clocks-v5-0-715b646d5206@disroot.org> <20250301-exynos7870-pmu-clocks-v5-2-715b646d5206@disroot.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/03/2025 19:16, Stephen Boyd wrote: > Quoting Kaustabh Chakraborty (2025-02-28 19:57:13) >> diff --git a/drivers/clk/samsung/clk-exynos7870.c b/drivers/clk/samsung/clk-exynos7870.c >> new file mode 100644 >> index 0000000000000000000000000000000000000000..2ec4a4e489be30bd1cd2e6deac006bb8ac5bdc57 >> --- /dev/null >> +++ b/drivers/clk/samsung/clk-exynos7870.c >> @@ -0,0 +1,1830 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (C) 2015 Samsung Electronics Co., Ltd. >> + * Author: Kaustabh Chakraborty >> + * >> + * Common Clock Framework support for Exynos7870. >> + */ >> + >> +#include > > Please remove this include as this is a clk provider and not a clk > consumer. I fixed it up for all drivers. > >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> + >> +#include "clk.h" >> +#include "clk-exynos-arm64.h" >> + >> +/* >> + * Register offsets for CMU_MIF (0x10460000) >> + */ > [...] >> + >> +static const struct samsung_cmu_info peri_cmu_info __initconst = { >> + .gate_clks = peri_gate_clks, >> + .nr_gate_clks = ARRAY_SIZE(peri_gate_clks), >> + .clk_regs = peri_clk_regs, >> + .nr_clk_regs = ARRAY_SIZE(peri_clk_regs), >> + .nr_clk_ids = PERI_NR_CLK, >> +}; >> + >> +static int __init exynos7870_cmu_probe(struct platform_device *pdev) >> +{ >> + const struct samsung_cmu_info *info; >> + struct device *dev = &pdev->dev; >> + >> + info = of_device_get_match_data(dev); > > Use device APIs please: device_get_match_data() I expect here a follow up patch. > >> + exynos_arm64_register_cmu(dev, dev->of_node, info); >> + >> + return 0; >> +} >> + >> +static const struct of_device_id exynos7870_cmu_of_match[] = { >> + { >> + .compatible = "samsung,exynos7870-cmu-mif", >> + .data = &mif_cmu_info, >> + }, { >> + .compatible = "samsung,exynos7870-cmu-dispaud", >> + .data = &dispaud_cmu_info, >> + }, { >> + .compatible = "samsung,exynos7870-cmu-fsys", >> + .data = &fsys_cmu_info, >> + }, { >> + .compatible = "samsung,exynos7870-cmu-g3d", >> + .data = &g3d_cmu_info, >> + }, { >> + .compatible = "samsung,exynos7870-cmu-isp", >> + .data = &isp_cmu_info, >> + }, { >> + .compatible = "samsung,exynos7870-cmu-mfcmscl", >> + .data = &mfcmscl_cmu_info, >> + }, { >> + .compatible = "samsung,exynos7870-cmu-peri", >> + .data = &peri_cmu_info, >> + }, { >> + }, >> +}; >> + >> +static struct platform_driver exynos7870_cmu_driver __refdata = { > > Having __refdata here looks wrong. > >> + .driver = { >> + .name = "exynos7870-cmu", >> + .of_match_table = exynos7870_cmu_of_match, >> + .suppress_bind_attrs = true, >> + }, >> + .probe = exynos7870_cmu_probe, >> +}; >> + >> +static int __init exynos7870_cmu_init(void) >> +{ >> + return platform_driver_register(&exynos7870_cmu_driver); > > Is this supposed to be platform_driver_probe()? All the __init markings > in the samsung clk driver look like potential problems if anything > defers or is made into a module. Indeed code is confusing but still correct. This is called from core_initcall and nothing referencing __init/refdata can defer nor be a module. There are modules but, AFAIR, they don't use __init/__refdata. The __refdata here was probably so this can reference __initconst in other places. As you pointed out, probably the correct solution is to use platform_driver_probe(). Best regards, Krzysztof