From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EBBF1BF33F; Tue, 27 May 2025 13:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748351314; cv=none; b=rJtfk94jRbhMCT2ZjPnasKayYekG4EYzTwrRKMwmg+g3NmjHq5S5aFzJcBd8725NKyq5L42L61MPRHX00lNLNQk+DXdd/KOxHUrPZHSi+JqoHJOFVNDXHx4jkzxYQv3w51oEXeaD03Lqp0BjSR1/o3MOo9nsI0kdhbDRXgS4CsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748351314; c=relaxed/simple; bh=GyqnFA67vNMTN7nBS4yxcioiT5LHr0wB3N3vtXA1fCM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kACdCE9Mcyd/VbTFrHXx+aXrTFbKUq8YOAodviUu4x85JEjurpIZDsHfxY2dEX1E166OilnWw3qRJ233TV0PKYVPS58kuy0PRJqgrpdveM1ZooTMz4wUwn2MU4jzbHQb/16rAQYjsuTS06L+JM/A7Yzk2bKeKsjetOe01PNUaec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=gy7K2xp2; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="gy7K2xp2" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4bN0OqR1WicbAsGpg+98F6Jxk6N5NYo/HvpHfvT3B+Y=; b=gy7K2xp2EulUgSavLtvFA+S4En PmyS+rHoXBivo3sZDakMNfe0jgxPTbD1PO7rEmmi8dvZ2cjCk5YBFZ9WJRiweg+8REBWi7AyI7TvY +DOro/bwZ30pjC4J3opv35bvs6p9t/p3sOJbYwHmgG6W1merhzgWmJ1r4QsM8Urt47uk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1uJu2V-00E4qc-Uh; Tue, 27 May 2025 15:08:19 +0200 Date: Tue, 27 May 2025 15:08:19 +0200 From: Andrew Lunn To: George Moussalem Cc: Konrad Dybcio , Krzysztof Kozlowski , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Philipp Zabel , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 1/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support Message-ID: <0c57cff8-c730-49cd-b056-ce8fd17c5253@lunn.ch> References: <20250525-ipq5018-ge-phy-v1-0-ddab8854e253@outlook.com> <20250525-ipq5018-ge-phy-v1-1-ddab8854e253@outlook.com> <9e00f85e-c000-40c8-b1b3-4ac085e5b9d1@kernel.org> <82484d59-df1c-4d0a-b626-2320d4f63c7e@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > > > > > > Would qcom,phy-to-phy-dac (boolean) do? > > > > > > > > > > Seems fine to me. > > > > > > > > Can the driver instead check for a phy reference? > > > > > > Do you mean using the existing phy-handle DT property or create a new DT property called 'qcom,phy-reference'? Either way, can add it for v2. > > > > I'm not sure how this is all wired up. Do you have an example of a DT > > with both configurations you described in your reply to Andrew? When a SoC interface is connected to a switch, the SoC interface has no real knowledge it is actually connected to a switch. All it knows is it has a link peer, and it does not know if that peer is 1cm away or 100m. It does nothing different. The switch has a phandle to the SoC interface, so it knows a bit more, but it would be a bit around about for the SoC interface to search the whole device tree to see if there is a switch with a phandle pointing to it. So for me, a bool property indicating a short 'cable' is the better solution. Andrew