From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [resend PATCH v4 2/5] clk: mediatek: mt2701-mmsys: switch to platform device probing (fwd) To: Julia Lawall , matthias.bgg@kernel.org Cc: ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com, ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@codeaurora.org, lee.jones@linaro.org, sean.wang@mediatek.com, gregkh@linuxfoundation.org, rdunlap@infradead.org, linux@armlinux.org.uk, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, mchehab@kernel.org, pi-cheng.chen@linaro.org, davem@davemloft.net, linux-kernel@vger.kernel.org, kbuild-all@01.org References: From: Matthias Brugger Message-ID: <11ba8df2-21f3-71e5-8467-813eda93f8ec@gmail.com> Date: Wed, 18 Jul 2018 16:58:32 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-ID: On 18/07/18 16:54, Julia Lawall wrote: > Please check on whether the kfree is still needed. No it is not needed, thanks for noting. Matthias > > julia > > ---------- Forwarded message ---------- > Date: Wed, 18 Jul 2018 22:03:48 +0800 > From: kbuild test robot > To: kbuild@01.org > Cc: Julia Lawall > Subject: Re: [resend PATCH v4 2/5] clk: mediatek: mt2701-mmsys: switch to > platform device probing > > In-Reply-To: <20180717220328.792-3-matthias.bgg@kernel.org> > References: <20180717220328.792-3-matthias.bgg@kernel.org> > TO: matthias.bgg@kernel.org > > Hi Matthias, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on sof-driver-fuweitax/master] > [also build test WARNING on v4.18-rc5 next-20180718] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/matthias-bgg-kernel-org/arm-arm64-mediatek-Fix-mmsys-device-probing/20180718-191916 > base: https://github.com/fuweitax/linux master > :::::: branch date: 3 hours ago > :::::: commit date: 3 hours ago > >>> drivers/clk/mediatek/clk-mt2701-mm.c:128:1-6: WARNING: invalid free of devm_ allocated data > > # https://github.com/0day-ci/linux/commit/555e11caac5f7729e8927939046adbfa2264f9f5 > git remote add linux-review https://github.com/0day-ci/linux > git remote update linux-review > git checkout 555e11caac5f7729e8927939046adbfa2264f9f5 > vim +128 drivers/clk/mediatek/clk-mt2701-mm.c > > e98621182 Shunli Wang 2016-11-04 122 > 555e11caa Matthias Brugger 2018-07-18 123 static int clk_mt2701_mm_remove(struct platform_device *pdev) > 555e11caa Matthias Brugger 2018-07-18 124 { > 555e11caa Matthias Brugger 2018-07-18 125 struct clk_mt2701_mm_priv *private = platform_get_drvdata(pdev); > 555e11caa Matthias Brugger 2018-07-18 126 > 555e11caa Matthias Brugger 2018-07-18 127 kfree(private->clk_data); > 555e11caa Matthias Brugger 2018-07-18 @128 kfree(private); > 555e11caa Matthias Brugger 2018-07-18 129 > 555e11caa Matthias Brugger 2018-07-18 130 return 0; > 555e11caa Matthias Brugger 2018-07-18 131 } > 555e11caa Matthias Brugger 2018-07-18 132 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation >