From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Marek Vasut <marex@denx.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/1] clk: rs9: Fix suspend/resume
Date: Tue, 21 Mar 2023 07:20:50 +0100 [thread overview]
Message-ID: <12182972.O9o76ZdvQC@steina-w> (raw)
In-Reply-To: <47c091b45aac1dc7a88e154a70e9a655.sboyd@kernel.org>
Am Montag, 20. März 2023, 20:35:41 CET schrieb Stephen Boyd:
> Quoting Alexander Stein (2023-03-14 00:22:07)
>
> > Am Montag, 13. M�rz 2023, 23:26:54 CET schrieb Stephen Boyd:
> > > Quoting Alexander Stein (2023-03-09 23:49:40)
> > >
> > > > Disabling the cache in commit 2ff4ba9e3702 ("clk: rs9: Fix I2C
> > > > accessors")
> > > > without removing cache synchronization in resume path results in a
> > > > kernel panic as map->cache_ops is unset, due to REGCACHE_NONE.
> > > > Enable flat cache again to support resume again. num_reg_defaults_raw
> > > > is necessary to read the cache defaults from hardware. Some registers
> > > > are strapped in hardware and cannot be provided in software.
> > > >
> > > > Fixes: 2ff4ba9e3702 ("clk: rs9: Fix I2C accessors")
> > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > ---
> > > > There is also a series to not panic when using regcache_sync on
> > > > REGCACHE_NONE maps at [1].
> > >
> > > And it was rejected?
> >
> > v2 has been accepted and is available at [1] in regmap's for-next branch.
>
> So this still needs to be applied and backported to fix stable kernels?
IMHO yes, because without cache nothing will be stored/restored upon suspend/
resume. The other patch in regcache was just to ensure broken drivers (like
this one in the current state) do not crash the kernel.
Best regards,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2023-03-21 6:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 7:49 [PATCH 1/1] clk: rs9: Fix suspend/resume Alexander Stein
2023-03-13 22:26 ` Stephen Boyd
2023-03-14 7:22 ` Alexander Stein
2023-03-20 19:35 ` Stephen Boyd
2023-03-21 6:20 ` Alexander Stein [this message]
2023-03-21 17:47 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12182972.O9o76ZdvQC@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=linux-clk@vger.kernel.org \
--cc=marex@denx.de \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox