Re: [PATCH 5/5] arm64: dts: mt8173: add timer node

Daniel Kurtz
2015-07-14T04:27:34Z

On Tue, Jul 14, 2015 at 12:26 PM, Daniel Kurtz <djkurtz@chromium.org> wrote:
> On Mon, Jul 13, 2015 at 5:32 PM, Yingjoe Chen <yingjoe.chen@mediatek.com> wrote:
>> From: Daniel Kurtz <djkurtz@chromium.org>
>>
>> Add device node to enable GPT timer. This timer will be
>> used as sched clock source.
>>
>> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
>> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
>> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
>
> This binding needs documentation.

Whoops. I just found it at:
Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt

>
>> ---
>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> index 0696f8f..04bdd8f 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> @@ -219,6 +219,15 @@
>> reg = <0 0x10007000 0 0x100>;
>> };
>>
>> + timer: timer@10008000 {
>> + compatible = "mediatek,mt8173-timer",
>> + "mediatek,mt6577-timer";
>> + reg = <0 0x10008000 0 0x1000>;
>> + interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_LOW>;
>> + clocks = <&infracfg CLK_INFRA_CLK_13M>,
>> + <&topckgen CLK_TOP_RTC_SEL>;
>
> Why two clocks? The driver only uses one.
> Please use a clock-names property.
>
> Thanks,
> -Dan
>
>> + };
>> +
>> pwrap: pwrap@1000d000 {
>> compatible = "mediatek,mt8173-pwrap";
>> reg = <0 0x1000d000 0 0x1000>;
>> --
>> 1.8.1.1.dirty
>>