From: Andre Przywara <andre.przywara@arm.com>
To: "Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Emilio López" <emilio@elopez.com.ar>,
"Michael Turquette" <mturquette@baylibre.com>,
"Chen-Yu Tsai" <wens@csie.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] clk: sunxi: error checking on clock setup
Date: Fri, 12 Feb 2016 15:11:50 +0000 [thread overview]
Message-ID: <1455289913-29514-1-git-send-email-andre.przywara@arm.com> (raw)
Since I promised to do this some days ago:
Setting up the clocks properly is quite critical to the system's
operation, but currently our error handling is not very verbose.
This series adds error handling and reporting to the sunxi clocks,
so that any errors are correctly detected and reported. Also previous
actions are rolled back in case something went wrong.
This proves to be helpful in debugging clock tree issues,
especially when adding support for new SoCs.
I tested this on a BananaPi by deliberately misspelling
"clock-output-names". The resulting kernel crash in
sun4i_timer_interrupt is totally misleading, but now there is a line
in the dmesg before saying:
=======
sunxi_divider_clk_setup: could not read clock-output-names for "apb0"
=======
This applies on top of Maxime's sunxi/for-next branch.
Please have a look (and apply, if you like it).
Cheers,
Andre.
Andre Przywara (3):
clk: sunxi: improve mux_clk error handling and reporting
clk: sunxi: improve divider_clk error handling and reporting
clk: sunxi: Improve divs_clk error handling and reporting
drivers/clk/sunxi/clk-sunxi.c | 68 +++++++++++++++++++++++++++++++++++--------
1 file changed, 56 insertions(+), 12 deletions(-)
--
2.6.4
next reply other threads:[~2016-02-12 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 15:11 Andre Przywara [this message]
2016-02-12 15:11 ` [PATCH 1/3] clk: sunxi: improve mux_clk error handling and reporting Andre Przywara
2016-02-13 2:44 ` Chen-Yu Tsai
2016-02-16 9:45 ` Andre Przywara
2016-02-16 9:59 ` Chen-Yu Tsai
2016-02-16 10:04 ` Andre Przywara
2016-02-16 10:02 ` Maxime Ripard
2016-02-12 15:11 ` [PATCH 2/3] clk: sunxi: improve divider_clk " Andre Przywara
2016-02-12 15:11 ` [PATCH 3/3] clk: sunxi: Improve divs_clk " Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455289913-29514-1-git-send-email-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=emilio@elopez.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox