From: Philipp Zabel <p.zabel@pengutronix.de>
To: Jiancheng Xue <xuejiancheng@hisilicon.com>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
yanhaifeng@hisilicon.com, haojian.zhuang@linaro.org,
zhangfei.gao@linaro.org, xuwei5@hisilicon.com,
yanghongwei@hisilicon.com
Subject: Re: [PATCH 1/5] reset: hisilicon: change the definition of hisi_reset_init
Date: Tue, 10 May 2016 13:09:50 +0200 [thread overview]
Message-ID: <1462878590.3050.5.camel@pengutronix.de> (raw)
In-Reply-To: <1462871953-26606-2-git-send-email-xuejiancheng@hisilicon.com>
Hi Jiancheng,
Am Dienstag, den 10.05.2016, 17:19 +0800 schrieb Jiancheng Xue:
> Change the input arguments type to struct platform_device pointer.
>
> Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
[...]
> diff --git a/drivers/clk/hisilicon/reset.h b/drivers/clk/hisilicon/reset.h
> index 677d773..9a69374 100644
> --- a/drivers/clk/hisilicon/reset.h
> +++ b/drivers/clk/hisilicon/reset.h
> @@ -22,10 +22,11 @@ struct device_node;
> struct hisi_reset_controller;
>
> #ifdef CONFIG_RESET_CONTROLLER
> -struct hisi_reset_controller *hisi_reset_init(struct device_node *np);
> +struct hisi_reset_controller *hisi_reset_init(struct platform_device *pdev);
Changing this without changing the call to hisi_reset_init() in
hi3519_clk_probe at the same time will break compilation until
patch 5 is applied.
regards
Philipp
next prev parent reply other threads:[~2016-05-10 11:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 9:19 [PATCH 0/5] clk: hisilicon: Fix some problems of clk-hi3519 Jiancheng Xue
2016-05-10 9:19 ` [PATCH 1/5] reset: hisilicon: change the definition of hisi_reset_init Jiancheng Xue
2016-05-10 11:09 ` Philipp Zabel [this message]
2016-05-10 9:19 ` [PATCH 2/5] clk: hisilicon: add hisi_clk_alloc function Jiancheng Xue
2016-05-10 9:19 ` [PATCH 3/5] clk: hisilicon: add error processing for hisi_clk_register_* functions Jiancheng Xue
2016-05-10 9:19 ` [PATCH 4/5] clk: hisilicon: add hisi_clk_unregister_* functions Jiancheng Xue
2016-05-10 9:19 ` [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and fix some issues Jiancheng Xue
2016-05-10 11:09 ` Philipp Zabel
2016-05-10 11:46 ` Jiancheng Xue
2016-05-13 0:09 ` [PATCH 0/5] clk: hisilicon: Fix some problems of clk-hi3519 Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462878590.3050.5.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=haojian.zhuang@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=xuejiancheng@hisilicon.com \
--cc=xuwei5@hisilicon.com \
--cc=yanghongwei@hisilicon.com \
--cc=yanhaifeng@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).