Re: [PATCH 3/6] dt/bindings: Add bindings for Tegra GMI controller

Jon Hunter
2016-08-23T14:48:25Z

On 23/08/16 11:33, Mirza Krak wrote:

...

> Like we discussed I am now trying to implement this but without
> success and I am starting to think that it is not that simple unless I
> am missing something.
>
> Below tree
>
> gmi@70009000 {
> status = "okay";
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <4 0x48000000 0x7ffffff>;
>
> bus@4 {
> compatible = "simple-bus";
> reg = <4 0>;

I don't think you want reg here.

> #address-cells = <1>;
> #size-cells = <1>;

May be ranges here?

> nvidia,snor-mux-mode;
> nvidia,snor-adv-inv;
>
> can@0 {
> compatible = "nxp,sja1000";
> reg = <0 0x100>;
> ....
> };
>
> can@40000 {
> compatible = "nxp,sja1000";
> reg = <0x40000 0x100>;
> ....
> };
> };
> };

Have a look at some other drivers for example:

Documentation/devicetree/bindings/memory-controllers/arm,pl172.txt

Cheers
Jon

--
nvpublic