From: Yoshihiro Kaneko <ykaneko0929@gmail.com>
To: linux-clk@vger.kernel.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org
Subject: [PATCH/RFC 2/2] clk: renesas: r8a7795: Do rounding for calculated frequency value
Date: Mon, 8 Aug 2016 02:58:12 +0900 [thread overview]
Message-ID: <1470592692-3486-3-git-send-email-ykaneko0929@gmail.com> (raw)
In-Reply-To: <1470592692-3486-1-git-send-email-ykaneko0929@gmail.com>
From: Dien Pham <dien.pham.ry@rvc.renesas.com>
The calculation value has some errors after some calculation,
especially, when one of the input value is odd value.
This patch applies rounding to closest frequency at 100Mhz unit.
Signed-off-by: Dien Pham <dien.pham.ry@rvc.renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
drivers/clk/renesas/clk-rcar-gen2.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/renesas/clk-rcar-gen2.c b/drivers/clk/renesas/clk-rcar-gen2.c
index 7519f71..5c4dcc7 100644
--- a/drivers/clk/renesas/clk-rcar-gen2.c
+++ b/drivers/clk/renesas/clk-rcar-gen2.c
@@ -60,13 +60,16 @@ static unsigned long cpg_z_clk_recalc_rate(struct clk_hw *hw,
struct cpg_z_clk *zclk = to_z_clk(hw);
unsigned int mult;
unsigned int val;
+ unsigned long rate;
val = (clk_readl(zclk->reg) & CPG_FRQCRC_ZFC_MASK)
>> CPG_FRQCRC_ZFC_SHIFT;
mult = 32 - val;
- /* Add 1/2 to reduce the math error that raises by math rounding */
- return div_u64((u64)parent_rate * mult + 16, 32);
+ rate = div_u64((u64)parent_rate * mult + 16, 32);
+ /* Round to closest value at 100MHz unit */
+ rate = 100000000 * DIV_ROUND_CLOSEST(rate, 100000000);
+ return rate;
}
static long cpg_z_clk_round_rate(struct clk_hw *hw, unsigned long rate,
--
1.9.1
prev parent reply other threads:[~2016-08-07 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 17:58 [PATCH/RFC 0/2] clk: renesas: r8a7795: improve z clock rate Yoshihiro Kaneko
2016-08-07 17:58 ` [PATCH/RFC 1/2] clk: renesas: r8a7795: Improve the calculated value of Clock Yoshihiro Kaneko
2016-08-07 17:58 ` Yoshihiro Kaneko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470592692-3486-3-git-send-email-ykaneko0929@gmail.com \
--to=ykaneko0929@gmail.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox