From: Scott Wood <oss@buserror.net>
To: yuantian.tang@nxp.com, mturquette@baylibre.com
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
scott.wood@nxp.com
Subject: Re: [PATCH] clk: qoriq: fix a register offset error
Date: Mon, 15 Aug 2016 11:32:02 -0500 [thread overview]
Message-ID: <1471278722.25630.268.camel@buserror.net> (raw)
In-Reply-To: <1471246100-40713-1-git-send-email-yuantian.tang@nxp.com>
On Mon, 2016-08-15 at 15:28 +0800, yuantian.tang@nxp.com wrote:
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
>
> The offset of Core Cluster clock control/status register
> on cluster group V3 version is different from others, and
> should be plus 0x70000.
>
> Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
> ---
> drivers/clk/clk-qoriq.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
> index f4c455a..05e416c 100644
> --- a/drivers/clk/clk-qoriq.c
> +++ b/drivers/clk/clk-qoriq.c
> @@ -774,7 +774,11 @@ static struct clk * __init create_one_cmux(struct
> clockgen *cg, int idx)
> if (!hwc)
> return NULL;
>
> - hwc->reg = cg->regs + 0x20 * idx;
> + if (cg->info.flags & CG_VER3)
> + hwc->reg = cg->regs + 0x70000 + 0x20 * idx;
> + else
> + hwc->reg = cg->regs + 0x20 * idx;
> +
> hwc->info = cg->info.cmux_groups[cg->info.cmux_to_group[idx]];
Reviewed-by: Scott Wood <oss@buserror.net>
-Scott
next prev parent reply other threads:[~2016-08-15 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 7:28 [PATCH] clk: qoriq: fix a register offset error yuantian.tang
2016-08-15 16:32 ` Scott Wood [this message]
2016-08-18 23:51 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471278722.25630.268.camel@buserror.net \
--to=oss@buserror.net \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=scott.wood@nxp.com \
--cc=yuantian.tang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).