From: Leonard Crestez <leonard.crestez@nxp.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
<devicetree@vger.kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>, <kernel@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Michael Turquette" <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Shawn Guo <shawnguo@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH v5 3/6] kernel/reboot.c: export pm_power_off_prepare
Date: Mon, 19 Jun 2017 14:35:09 +0300 [thread overview]
Message-ID: <1497872109.5380.10.camel@nxp.com> (raw)
In-Reply-To: <20170619050245.2632-4-o.rempel@pengutronix.de>
On Mon, 2017-06-19 at 07:02 +0200, Oleksij Rempel wrote:
> Export pm_power_off_prepare. It is needed to implement power off on
> Freescale/NXP iMX6 based boards with external power management
> integrated circuit (PMIC).
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> kernel/reboot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> index bd30a973fe94..a6903bf772c7 100644
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -49,6 +49,7 @@ int reboot_force;
> */
>
> void (*pm_power_off_prepare)(void);
> +EXPORT_SYMBOL(pm_power_off_prepare);
>
Could you register a reboot notifier in the pfuze driver instead? Right
now the only user of pm_power_off_prepare is ACPI so this alternative
seems less intrusive.
--
Regards,
Leonard
next prev parent reply other threads:[~2017-06-19 11:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 5:02 [PATCH v5 0/6] provide power off support for iMX6 with external PMIC Oleksij Rempel
2017-06-19 5:02 ` [PATCH v5 1/6] ARM: imx6q: provide documentation for new fsl,pmic-stby-poweroff property Oleksij Rempel
2017-06-19 5:02 ` [PATCH v5 2/6] ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set Oleksij Rempel
2017-06-19 11:35 ` Leonard Crestez
2017-06-20 4:55 ` Oleksij Rempel
2017-06-20 14:32 ` Leonard Crestez
2017-06-20 15:25 ` Oleksij Rempel
2017-06-19 5:02 ` [PATCH v5 3/6] kernel/reboot.c: export pm_power_off_prepare Oleksij Rempel
2017-06-19 11:35 ` Leonard Crestez [this message]
2017-06-20 5:01 ` Oleksij Rempel
2017-06-20 14:37 ` Leonard Crestez
2017-06-20 15:29 ` Oleksij Rempel
2017-06-19 5:02 ` [PATCH v5 4/6] regulator: pfuze100: add fsl,pmic-stby-poweroff property Oleksij Rempel
2017-06-19 5:02 ` [PATCH v5 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler Oleksij Rempel
2017-06-19 5:02 ` [PATCH v5 6/6] ARM: dts: imx6: RIoTboard provide standby on power off option Oleksij Rempel
2017-06-20 0:19 ` Stephen Boyd
2017-06-20 4:02 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497872109.5380.10.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=o.rempel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).