From: Stefan Agner <stefan@agner.ch>
To: Fabio Estevam <fabio.estevam@nxp.com>
Cc: sboyd@codeaurora.org, shawnguo@kernel.org, kernel@pengutronix.de,
linux-clk@vger.kernel.org, leonard.crestez@nxp.com,
festevam@gmail.com
Subject: Re: [PATCH] clk: imx7d: Fix the DDR PLL enable bit
Date: Tue, 06 Jun 2017 09:29:40 -0700 [thread overview]
Message-ID: <14dcf8601d35d32124df7fbbd0ccc3d5@agner.ch> (raw)
In-Reply-To: <1496763954-10981-1-git-send-email-fabio.estevam@nxp.com>
On 2017-06-06 08:45, Fabio Estevam wrote:
> Commit ad14972422899b6 ("clk: imx7d: Fix the powerdown bit location
> of PLL DDR") used the incorrect bit for the IMX_PLLV3_DDR_IMX7 case.
>
> Fix it accordingly to avoid a kernel hang.
Yeah that sneaked in with the rename of the define between v1 -> v2,
didn't saw that sorry.
FWIW,
Reviewed-by: Stefan Agner <stefan@agner.ch>
--
Stefan
>
> Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/clk/imx/clk-pllv3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
> index 0039b16..9af62ee 100644
> --- a/drivers/clk/imx/clk-pllv3.c
> +++ b/drivers/clk/imx/clk-pllv3.c
> @@ -453,7 +453,7 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type
> type, const char *name,
> ops = &clk_pllv3_enet_ops;
> break;
> case IMX_PLLV3_DDR_IMX7:
> - pll->power_bit = IMX7_ENET_PLL_POWER;
> + pll->power_bit = IMX7_DDR_PLL_POWER;
> ops = &clk_pllv3_av_ops;
> break;
> default:
next prev parent reply other threads:[~2017-06-06 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 15:45 [PATCH] clk: imx7d: Fix the DDR PLL enable bit Fabio Estevam
2017-06-06 16:29 ` Stefan Agner [this message]
2017-06-07 0:42 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14dcf8601d35d32124df7fbbd0ccc3d5@agner.ch \
--to=stefan@agner.ch \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-clk@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).