* [PATCH v1 1/1] clk: Remove redundant selection of RATIONAL
@ 2018-01-19 17:44 Andy Shevchenko
2018-01-29 15:46 ` Andy Shevchenko
2018-03-16 23:32 ` Stephen Boyd
0 siblings, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2018-01-19 17:44 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, linux-clk; +Cc: Andy Shevchenko
Since the commit
0777591e715a ("clk: fractional-divider: switch to rational best approximation")
enables rational best approximation to all common based clocks, there is
no need to repeat the selection in each of them.
No functional changes intended.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/clk/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 98ce9fc6e6c0..2e65cf731b00 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -76,7 +76,6 @@ config COMMON_CLK_SI5351
tristate "Clock driver for SiLabs 5351A/B/C"
depends on I2C
select REGMAP_I2C
- select RATIONAL
---help---
This driver supports Silicon Labs 5351A/B/C programmable clock
generators.
@@ -105,7 +104,6 @@ config COMMON_CLK_CDCE706
tristate "Clock driver for TI CDCE706 clock synthesizer"
depends on I2C
select REGMAP_I2C
- select RATIONAL
---help---
This driver supports TI CDCE706 programmable 3-PLL clock synthesizer.
--
2.15.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] clk: Remove redundant selection of RATIONAL
2018-01-19 17:44 [PATCH v1 1/1] clk: Remove redundant selection of RATIONAL Andy Shevchenko
@ 2018-01-29 15:46 ` Andy Shevchenko
2018-03-16 14:22 ` Andy Shevchenko
2018-03-16 23:32 ` Stephen Boyd
1 sibling, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2018-01-29 15:46 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, linux-clk
On Fri, 2018-01-19 at 19:44 +0200, Andy Shevchenko wrote:
> Since the commit
>
> 0777591e715a ("clk: fractional-divider: switch to rational best
> approximation")
>
> enables rational best approximation to all common based clocks, there
> is
> no need to repeat the selection in each of them.
>
> No functional changes intended.
Any comment on this?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/clk/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 98ce9fc6e6c0..2e65cf731b00 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -76,7 +76,6 @@ config COMMON_CLK_SI5351
> tristate "Clock driver for SiLabs 5351A/B/C"
> depends on I2C
> select REGMAP_I2C
> - select RATIONAL
> ---help---
> This driver supports Silicon Labs 5351A/B/C programmable
> clock
> generators.
> @@ -105,7 +104,6 @@ config COMMON_CLK_CDCE706
> tristate "Clock driver for TI CDCE706 clock synthesizer"
> depends on I2C
> select REGMAP_I2C
> - select RATIONAL
> ---help---
> This driver supports TI CDCE706 programmable 3-PLL clock
> synthesizer.
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] clk: Remove redundant selection of RATIONAL
2018-01-29 15:46 ` Andy Shevchenko
@ 2018-03-16 14:22 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2018-03-16 14:22 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, linux-clk
On Mon, 2018-01-29 at 17:46 +0200, Andy Shevchenko wrote:
> On Fri, 2018-01-19 at 19:44 +0200, Andy Shevchenko wrote:
> > Since the commit
> >
> > 0777591e715a ("clk: fractional-divider: switch to rational best
> > approximation")
> >
> > enables rational best approximation to all common based clocks,
> > there
> > is
> > no need to repeat the selection in each of them.
> >
> > No functional changes intended.
>
> Any comment on this?
Do we have any active maintainer for clock related patches?
Who is that right now?
Can we somehow keep patches commented?
>
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/clk/Kconfig | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> > index 98ce9fc6e6c0..2e65cf731b00 100644
> > --- a/drivers/clk/Kconfig
> > +++ b/drivers/clk/Kconfig
> > @@ -76,7 +76,6 @@ config COMMON_CLK_SI5351
> > tristate "Clock driver for SiLabs 5351A/B/C"
> > depends on I2C
> > select REGMAP_I2C
> > - select RATIONAL
> > ---help---
> > This driver supports Silicon Labs 5351A/B/C programmable
> > clock
> > generators.
> > @@ -105,7 +104,6 @@ config COMMON_CLK_CDCE706
> > tristate "Clock driver for TI CDCE706 clock synthesizer"
> > depends on I2C
> > select REGMAP_I2C
> > - select RATIONAL
> > ---help---
> > This driver supports TI CDCE706 programmable 3-PLL clock
> > synthesizer.
> >
>
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] clk: Remove redundant selection of RATIONAL
2018-01-19 17:44 [PATCH v1 1/1] clk: Remove redundant selection of RATIONAL Andy Shevchenko
2018-01-29 15:46 ` Andy Shevchenko
@ 2018-03-16 23:32 ` Stephen Boyd
2018-03-19 9:20 ` Andy Shevchenko
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2018-03-16 23:32 UTC (permalink / raw)
To: Andy Shevchenko, Michael Turquette, Stephen Boyd, linux-clk
Cc: Andy Shevchenko
Quoting Andy Shevchenko (2018-01-19 09:44:01)
> Since the commit
> =
> 0777591e715a ("clk: fractional-divider: switch to rational best approxi=
mation")
> =
> enables rational best approximation to all common based clocks, there is
> no need to repeat the selection in each of them.
> =
> No functional changes intended.
> =
I'd prefer we leave it alone. It would be better to push the basic clk
types into Kconfig and then have platforms select the ones they want to
use.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] clk: Remove redundant selection of RATIONAL
2018-03-16 23:32 ` Stephen Boyd
@ 2018-03-19 9:20 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2018-03-19 9:20 UTC (permalink / raw)
To: Stephen Boyd, Michael Turquette, Stephen Boyd, linux-clk
On Fri, 2018-03-16 at 16:32 -0700, Stephen Boyd wrote:
> Quoting Andy Shevchenko (2018-01-19 09:44:01)
> > Since the commit
> >
> > 0777591e715a ("clk: fractional-divider: switch to rational best
> > approximation")
> >
> > enables rational best approximation to all common based clocks,
> > there is
> > no need to repeat the selection in each of them.
> >
> > No functional changes intended.
> >
>
> I'd prefer we leave it alone. It would be better to push the basic clk
> types into Kconfig and then have platforms select the ones they want
> to
> use.
Fair enough.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-19 9:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19 17:44 [PATCH v1 1/1] clk: Remove redundant selection of RATIONAL Andy Shevchenko
2018-01-29 15:46 ` Andy Shevchenko
2018-03-16 14:22 ` Andy Shevchenko
2018-03-16 23:32 ` Stephen Boyd
2018-03-19 9:20 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).