* [PATCH] clk: meson: audio-divider is one based
@ 2018-06-19 15:47 Jerome Brunet
2018-06-20 8:31 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Jerome Brunet @ 2018-06-19 15:47 UTC (permalink / raw)
To: Neil Armstrong, Kevin Hilman, Carlo Caione
Cc: Jerome Brunet, linux-amlogic, linux-clk, linux-kernel
The audio divider is one based. This offset was mistakenly dropped from
recalc_rate() when migrating to clk_regmap.
Fixes: 88a4e1283681 ("clk: meson: migrate the audio divider clock to clk_regmap")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/meson/clk-audio-divider.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/meson/clk-audio-divider.c b/drivers/clk/meson/clk-audio-divider.c
index 58f546e04807..e4cf96ba704e 100644
--- a/drivers/clk/meson/clk-audio-divider.c
+++ b/drivers/clk/meson/clk-audio-divider.c
@@ -51,7 +51,7 @@ static unsigned long audio_divider_recalc_rate(struct clk_hw *hw,
struct meson_clk_audio_div_data *adiv = meson_clk_audio_div_data(clk);
unsigned long divider;
- divider = meson_parm_read(clk->map, &adiv->div);
+ divider = meson_parm_read(clk->map, &adiv->div) + 1;
return DIV_ROUND_UP_ULL((u64)parent_rate, divider);
}
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: meson: audio-divider is one based
2018-06-19 15:47 [PATCH] clk: meson: audio-divider is one based Jerome Brunet
@ 2018-06-20 8:31 ` Neil Armstrong
2018-06-22 10:41 ` Jerome Brunet
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2018-06-20 8:31 UTC (permalink / raw)
To: Jerome Brunet, Kevin Hilman, Carlo Caione
Cc: linux-amlogic, linux-clk, linux-kernel
On 19/06/2018 17:47, Jerome Brunet wrote:
> The audio divider is one based. This offset was mistakenly dropped from
> recalc_rate() when migrating to clk_regmap.
>
> Fixes: 88a4e1283681 ("clk: meson: migrate the audio divider clock to clk_regmap")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/meson/clk-audio-divider.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/clk-audio-divider.c b/drivers/clk/meson/clk-audio-divider.c
> index 58f546e04807..e4cf96ba704e 100644
> --- a/drivers/clk/meson/clk-audio-divider.c
> +++ b/drivers/clk/meson/clk-audio-divider.c
> @@ -51,7 +51,7 @@ static unsigned long audio_divider_recalc_rate(struct clk_hw *hw,
> struct meson_clk_audio_div_data *adiv = meson_clk_audio_div_data(clk);
> unsigned long divider;
>
> - divider = meson_parm_read(clk->map, &adiv->div);
> + divider = meson_parm_read(clk->map, &adiv->div) + 1;
>
> return DIV_ROUND_UP_ULL((u64)parent_rate, divider);
> }
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: meson: audio-divider is one based
2018-06-20 8:31 ` Neil Armstrong
@ 2018-06-22 10:41 ` Jerome Brunet
0 siblings, 0 replies; 3+ messages in thread
From: Jerome Brunet @ 2018-06-22 10:41 UTC (permalink / raw)
To: Neil Armstrong, Kevin Hilman, Carlo Caione
Cc: linux-amlogic, linux-clk, linux-kernel
On Wed, 2018-06-20 at 10:31 +0200, Neil Armstrong wrote:
> On 19/06/2018 17:47, Jerome Brunet wrote:
> > The audio divider is one based. This offset was mistakenly dropped from
> > recalc_rate() when migrating to clk_regmap.
> >
> > Fixes: 88a4e1283681 ("clk: meson: migrate the audio divider clock to clk_regmap")
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> > ---
> > drivers/clk/meson/clk-audio-divider.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/meson/clk-audio-divider.c b/drivers/clk/meson/clk-audio-divider.c
> > index 58f546e04807..e4cf96ba704e 100644
> > --- a/drivers/clk/meson/clk-audio-divider.c
> > +++ b/drivers/clk/meson/clk-audio-divider.c
> > @@ -51,7 +51,7 @@ static unsigned long audio_divider_recalc_rate(struct clk_hw *hw,
> > struct meson_clk_audio_div_data *adiv = meson_clk_audio_div_data(clk);
> > unsigned long divider;
> >
> > - divider = meson_parm_read(clk->map, &adiv->div);
> > + divider = meson_parm_read(clk->map, &adiv->div) + 1;
> >
> > return DIV_ROUND_UP_ULL((u64)parent_rate, divider);
> > }
> >
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>
Applied for fixes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-22 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-19 15:47 [PATCH] clk: meson: audio-divider is one based Jerome Brunet
2018-06-20 8:31 ` Neil Armstrong
2018-06-22 10:41 ` Jerome Brunet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox