Re: [PATCH v11 4/5] soc / drm: mediatek: Move routing control to mmsys device

Matthias Brugger
2020-03-11T13:25:33Z

On 11/03/2020 14:07, CK Hu wrote:
> Hi, Enric:
>
> On Wed, 2020-03-11 at 12:56 +0100, Enric Balletbo i Serra wrote:
>> Provide a mtk_mmsys_ddp_connect() and mtk_mmsys_disconnect() functions to
>> replace mtk_ddp_add_comp_to_path() and mtk_ddp_remove_comp_from_path().
>> Those functions will allow DRM driver and others to control the data
>> path routing.
>>
>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
>

If I remember correctly you are OK me taking the patch through the SoC tree, right?

In this case I'd need a Acked-by tag. Not a big deal, just trying to remeber the
tag policy in the linux kernel :)

Regards,
Matthias

>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>> ---
>>
>> Changes in v11: None
>> Changes in v10:
>> - Select CONFIG_MTK_MMSYS (CK)
>> - Pass device pointer of mmsys device instead of config regs (CK)
>>
>> Changes in v9:
>> - Introduced a new patch to move routing control into mmsys driver.
>> - Removed the patch to use regmap as is not needed anymore.
>>
>> Changes in v8: None
>> Changes in v7: None
>>
>> drivers/gpu/drm/mediatek/Kconfig | 1 +
>> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 19 +-
>> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 256 ----------------------
>> drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 7 -
>> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 14 +-
>> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 +-
>> drivers/soc/mediatek/mtk-mmsys.c | 279 ++++++++++++++++++++++++
>> include/linux/soc/mediatek/mtk-mmsys.h | 20 ++
>> 8 files changed, 316 insertions(+), 282 deletions(-)
>> create mode 100644 include/linux/soc/mediatek/mtk-mmsys.h
>>
>