public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Vasut <marek.vasut@mailbox.org>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ARM: dts: renesas: r8a7740: Add ZT/ZTR trace clock on R-Mobile A1
Date: Thu, 23 Apr 2026 11:26:53 +0200	[thread overview]
Message-ID: <161eb29f-2d07-455a-bd74-4f22061b5dfb@kernel.org> (raw)
In-Reply-To: <0f933506-c196-4503-844f-2a375e2cf690@mailbox.org>

On 23/04/2026 01:33, Marek Vasut wrote:
> On 4/21/26 10:02 AM, Krzysztof Kozlowski wrote:
>> On Thu, Apr 16, 2026 at 01:31:40AM +0200, Marek Vasut wrote:
>>> Add ZT trace bus and ZTR trace clock on the R-Mobile A1.
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>> ---
>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>> Cc: Magnus Damm <magnus.damm@gmail.com>
>>> Cc: Michael Turquette <mturquette@baylibre.com>
>>> Cc: Rob Herring <robh@kernel.org>
>>> Cc: Stephen Boyd <sboyd@kernel.org>
>>> Cc: devicetree@vger.kernel.org
>>> Cc: linux-clk@vger.kernel.org
>>> Cc: linux-kernel@vger.kernel.org
>>> Cc: linux-renesas-soc@vger.kernel.org
>>> ---
>>> V2: Add ztr/zt clock at the end of the list to match bindings
>>> ---
>>>   arch/arm/boot/dts/renesas/r8a7740.dtsi    | 2 +-
>>
>>>   include/dt-bindings/clock/r8a7740-clock.h | 2 ++
>>
>> This goes to the binding patch.
>>
>> Didn't you have also a checkpatch warning?
> I only got this warning, but the docs 1/4 and includes 3/4 are a 
> separate patch in this series:
> 
> "
> WARNING: DT binding docs and includes should be a separate patch. See: 
> Documentation/devicetree/bindings/submitting-patches.rst

So you did not implement it... Include goes with the binding. Always.
Look at other commits.

Best regards,
Krzysztof

  reply	other threads:[~2026-04-23  9:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 23:31 [PATCH v2 0/4] Describe coresight on R-Mobile A1 Marek Vasut
2026-04-15 23:31 ` [PATCH v2 1/4] dt-bindings: clock: renesas,cpg-clocks: Document ZT/ZTR trace clock " Marek Vasut
2026-04-21  8:01   ` Krzysztof Kozlowski
2026-04-22 23:33     ` Marek Vasut
2026-04-15 23:31 ` [PATCH v2 2/4] clk: renesas: r8a7740: Implement " Marek Vasut
2026-04-15 23:31 ` [PATCH v2 3/4] ARM: dts: renesas: r8a7740: Add " Marek Vasut
2026-04-21  8:02   ` Krzysztof Kozlowski
2026-04-22 23:33     ` Marek Vasut
2026-04-23  9:26       ` Krzysztof Kozlowski [this message]
2026-04-23 10:00         ` Marek Vasut
2026-04-23 14:00           ` Krzysztof Kozlowski
2026-04-15 23:31 ` [PATCH v2 4/4] ARM: dts: renesas: r8a7740: Describe coresight " Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161eb29f-2d07-455a-bd74-4f22061b5dfb@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=marek.vasut@mailbox.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox