From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789422DC789; Tue, 17 Mar 2026 16:01:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763262; cv=none; b=szRgZ88sG6lo7L2Bqm6hiFTiiD4b/GbmVL3V6cJFFwvYJkyneH69QHqGmkuCv2VzOc6cjZFkRklN2zP9TH98tGlKwCXAAPr2uqhIawFDHjq0LwxmH8po4nz/sgLmC0cFlelaaLHR9Mil8oMtkQtz9mb9qMjUeBmwEvVRK4Qil8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763262; c=relaxed/simple; bh=ar3yj8StogAACqxc0g1Q58gXeJrr8mZ+2bxzvkTkjOs=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=PGY0EDp8D14ff7SOjzzxDU5pNpqVQx6bGO9WoVIbw5o5k9SUJVDzlhqx5BGM81ybQPbSDyMP5+VDYjjhi9XcUA9PBnEJ7yRx7qQrBOnDCI6+2nQ2Y14yxpPxgk3x8hc+jwu4pWTn0hO/QG3EaQ/m9v3o0mxWwWuM71JHJvQCays= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k9Agb7xp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k9Agb7xp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EB4AC19424; Tue, 17 Mar 2026 16:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773763262; bh=ar3yj8StogAACqxc0g1Q58gXeJrr8mZ+2bxzvkTkjOs=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=k9Agb7xpH5vuIK4BsgCwypCn/tGyR9IRfihGBGoPTb+fg9afIT88zZdXNUr+Wv0xw 6LW/an9uCuIVdLUkxfVy7sRLiTFhNVFM14ahS0dHRe6SbaCzxhbUXZ1itVcCaPb4km 5yYN02o6LNyvvZeJ52Q0f3pnukzvgNDTiZjgSRiKjyibAkpPpDx22nRDvtOxy9SJhA aghcZnENIEYM7frdpf65TRb1chVVRM5RdxCP6M79p7rE8SlfVwjrqZkPF8QJNvgAQd X0PvkWfk+1PyXLP2uTzy6wOvpC7zgX73uJL1IfjxGOwJe1PCHVtAO44FL8cHIIInAc FSpyhSTKqYlNA== Message-ID: <1671b8ce-cbf9-45ae-947b-f35d174be93e@kernel.org> Date: Tue, 17 Mar 2026 17:00:56 +0100 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 1/7] dt-bindings: media: qcom,x1e80100-camss: Add simple-mfd compatible From: Krzysztof Kozlowski To: Bryan O'Donoghue Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20260316-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v10-0-fdfe984fe941@linaro.org> <20260316-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v10-1-fdfe984fe941@linaro.org> <20260316-glaring-jaybird-from-wonderland-4f8fd6@quoll> <94f4fda4-504e-44eb-87f0-e34e557402f8@linaro.org> <471895f6-dc60-44d8-84ce-8ba0069110e4@kernel.org> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <471895f6-dc60-44d8-84ce-8ba0069110e4@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/03/2026 16:51, Krzysztof Kozlowski wrote: > On 16/03/2026 13:01, Bryan O'Donoghue wrote: >> On 16/03/2026 07:29, Krzysztof Kozlowski wrote: >>> On Mon, Mar 16, 2026 at 01:02:01AM +0000, Bryan O'Donoghue wrote: >>>> Add "simple-mfd" as a second compatible string to allow child nodes >>>> within the CAMSS block to probe as individual platform devices. >>>> >>>> Signed-off-by: Bryan O'Donoghue >>>> --- >>>> Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml | 8 ++++++-- >>>> 1 file changed, 6 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml >>>> index 2d1662ef522b7..b5654ef71bd89 100644 >>>> --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml >>>> +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml >>>> @@ -14,7 +14,11 @@ description: >>>> >>>> properties: >>>> compatible: >>>> - const: qcom,x1e80100-camss >>>> + oneOf: >>>> + - const: qcom,x1e80100-camss >>>> + - items: >>>> + - const: qcom,x1e80100-camss >>>> + - const: simple-mfd >>>> >>>> reg: >>>> maxItems: 17 >>>> @@ -191,7 +195,7 @@ examples: >>>> #size-cells = <2>; >>>> >>>> camss: isp@acb7000 { >>>> - compatible = "qcom,x1e80100-camss"; >>>> + compatible = "qcom,x1e80100-camss", "simple-mfd"; >>> >>> You do not have any children here. And if you checked the DTS, you >>> would see this does not work. >>> >>> Please post complete example and bindings. >>> >>> I suspect that after posting complete picture we will see this is not a >>> simple-mfd device (child depends on parent). >>> >>> Best regards, >>> Krzysztof >>> >> >> This is it: >> >> https://lore.kernel.org/r/20260316-x1e-camss-csi2-phy-dtsi-v2-3-859f3fa55790@linaro.org > > That's a DTS branch. > > This commit is simply incomplete and noop. Adding simple-mfd without > child makes no sense and no benefits. > > It's like adding a local variable in C code without any read/assignment. > >> >> Just broke up the series so that drivers/bindings could go through >> linux-media and the dtsi stuff through Bjorn. >> >> I actually got the idea from: >> >> commit fe6a952b567f6a771d087d2e969914f31574d6ab >> Author: Krzysztof Kozlowski >> Date: Fri Jan 27 20:40:50 2023 +0100 > > If you refer to my commits, at least read them. Do you see children > there? Yes. You have none. > > Plus trying to get 13 year old legacy device without dtbs_check warnings > is different thing than correcting a recently introduced bindings. > Terrible example to take... And if you find example from 20 years ago, > it will be even worse. > One more thing, that commit was still correct because it fulfilled the simple-mfd requirement of lack of dependency on the parent. I do not believe your code fulfills it. I am pretty sure it does not. See 2023 and 2022 talks, how to get your schema accepted in less than 10 iterations. Or please read writing bindings which *describes exactly that case*. We have it documented, I was speaking about this more than once. I also mentioned so many times - do not make random changes, just because you found commit doing something similar. You were cc-ed even on such remarks from my side, like discussion with Jorge were irrelevant work was used as arguments, instead of providing actual technical arguments. https://lore.kernel.org/all/0d381ad0-85d4-43de-a050-3b9ed03bf5d8@kernel.org/ Don't ever reference some irrelevant commits in the past just because something looks similar. It makes no sense. Devices are completely different. Best regards, Krzysztof