From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Andy Shevchenko Cc: Stephen Boyd , linux-kernel@vger.kernel.org, heikki.krogerus@linux.intel.com, Greg Kroah-Hartman , linux-clk@vger.kernel.org Subject: Re: [PATCH v4 4/6] clk: rockchip: save width in struct clk_fractional_divider Date: Tue, 14 Jul 2015 18:16:17 +0200 Message-ID: <1709104.30ipufp3Og@diego> In-Reply-To: <1436886723-111895-5-git-send-email-andriy.shevchenko@linux.intel.com> References: <1436886723-111895-1-git-send-email-andriy.shevchenko@linux.intel.com> <1436886723-111895-5-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: Am Dienstag, 14. Juli 2015, 18:12:01 schrieb Andy Shevchenko: > The ->mwidth and ->nwidth fields will be used by clk-fractional-divider when > it will be switched to rational base approximation algorithm. > > Signed-off-by: Andy Shevchenko Looks sane to me Reviewed-by: Heiko Stuebner > --- > drivers/clk/rockchip/clk.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c > index 2493881..be6c7fd 100644 > --- a/drivers/clk/rockchip/clk.c > +++ b/drivers/clk/rockchip/clk.c > @@ -135,9 +135,11 @@ static struct clk > *rockchip_clk_register_frac_branch(const char *name, div->flags = > div_flags; > div->reg = base + muxdiv_offset; > div->mshift = 16; > - div->mmask = 0xffff0000; > + div->mwidth = 16; > + div->mmask = GENMASK(div->mwidth - 1, 0) << div->mshift; > div->nshift = 0; > - div->nmask = 0xffff; > + div->nwidth = 16; > + div->nmask = GENMASK(div->nwidth - 1, 0) << div->nshift; > div->lock = lock; > div_ops = &clk_fractional_divider_ops;