Re: [PATCH v4 09/10] arm64: dts: bcm2712: Add external clock for RP1 chipset on Rpi5

Andrew Lunn
2024-11-24T19:41:35Z

On Sun, Nov 24, 2024 at 11:51:46AM +0100, Andrea della Porta wrote:
> The RP1 found on Raspberry Pi 5 board needs an external crystal at 50MHz.
> Add clk_rp1_xosc node to provide that.

I'm wondering if this is the correct place for this clock. From your
description, the bcm2712 itself does not provide the clock. There is a
crystal on the board. So the board provides the clock. What happens
when the RP1 is used on other boards? Also, does the RP1 need an
actual crystal, or can you feed it a clock? Often such inputs are
flexible, you can connect a crystal across two pins, or you can feed a
clock into one pin.

If a crystal is the only choice, i would probably have it part of the
RP1 overlay. If a clock can be used, i would make it a board property.

Andrew