public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Robert Marko <robert.marko@sartura.hr>, Conor Dooley <conor@kernel.org>
Cc: <robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<gregkh@linuxfoundation.org>, <claudiu.beznea@tuxon.dev>,
	<mturquette@baylibre.com>, <sboyd@kernel.org>,
	<richardcochran@gmail.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-clk@vger.kernel.org>, <daniel.machon@microchip.com>,
	<UNGLinuxDriver@microchip.com>, <luka.perkov@sartura.hr>
Subject: Re: [PATCH 4/4] arm64: dts: microchip: add LAN969x support
Date: Mon, 15 Dec 2025 13:32:03 +0100	[thread overview]
Message-ID: <173412c8-c2fb-4c38-8de7-5b1c2eebdbf9@microchip.com> (raw)
In-Reply-To: <CA+HBbNGdd-u=4PtXZtirqRkFBhKwraa5gV-32QChDDjfVARPRg@mail.gmail.com>

Robert,

On 15/12/2025 at 12:36, Robert Marko wrote:
> On Wed, Dec 3, 2025 at 8:21 PM Conor Dooley <conor@kernel.org> wrote:
>>
>> On Wed, Dec 03, 2025 at 01:21:32PM +0100, Robert Marko wrote:
>>> Add support for Microchip LAN969x switch SoC, including the EV23X71A
>>> EVB board.
>>>
>>> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
>>> ---
>>>   arch/arm64/boot/dts/microchip/Makefile        |   2 +
>>>   .../boot/dts/microchip/lan9696-ev23x71a.dts   | 761 ++++++++++++++++++
>>
>>>   arch/arm64/boot/dts/microchip/lan969x.dtsi    | 482 +++++++++++
>>
>> The majority of devices in this file are missing soc-specific
>> compatibles.
> 
> Hi,
> I missed this before.
> 
> The majority of the devices are simply reused from the AT91 series, so
> I thought it was not required to
> update all of the bindings to add the LAN9691 compatible.
> 
> If that is required, I will do so in v2.
Well, history told us it was better (in addition to be required by DT 
best practices). Indeed, even if the same IP block is used, sometimes 
integration subtleties pay game with us and a dedicated compatible 
string saves us.

Regards,
   Nicolas

  reply	other threads:[~2025-12-15 12:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-03 12:21 [PATCH 1/4] dt-bindings: usb: Add Microchip LAN969x support Robert Marko
2025-12-03 12:21 ` [PATCH 2/4] dt-bindings: arm: Document Microchip LAN969x Robert Marko
2025-12-03 19:19   ` Conor Dooley
2025-12-08 10:30     ` Robert Marko
2025-12-08 17:10       ` Conor Dooley
2025-12-12 10:09         ` Robert Marko
2025-12-12 17:55           ` Conor Dooley
2025-12-03 12:21 ` [PATCH 3/4] include: dt-bindings: add LAN969x clock bindings Robert Marko
2025-12-03 19:22   ` Conor Dooley
2025-12-03 12:21 ` [PATCH 4/4] arm64: dts: microchip: add LAN969x support Robert Marko
2025-12-03 19:21   ` Conor Dooley
2025-12-15 11:36     ` Robert Marko
2025-12-15 12:32       ` Nicolas Ferre [this message]
2025-12-15 13:31         ` Robert Marko
2025-12-06 13:53   ` Claudiu Beznea
2025-12-06 18:06     ` Andrew Lunn
2025-12-08 17:15   ` Conor Dooley
2025-12-06 11:27 ` [PATCH 1/4] dt-bindings: usb: Add Microchip " Claudiu Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173412c8-c2fb-4c38-8de7-5b1c2eebdbf9@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=daniel.machon@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=luka.perkov@sartura.hr \
    --cc=mturquette@baylibre.com \
    --cc=richardcochran@gmail.com \
    --cc=robert.marko@sartura.hr \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox