public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Alexandru Chimac <alex@chimac.ro>
Cc: Conor Dooley <conor+dt@kernel.org>,
	 Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-clk@vger.kernel.org,  linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 Alim Akhtar <alim.akhtar@samsung.com>,
	 Krzysztof Kozlowski <krzk@kernel.org>,
	 Alexandru Chimac <alexchimac@protonmail.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	 devicetree@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 linux-samsung-soc@vger.kernel.org,
	 Michael Turquette <mturquette@baylibre.com>
Subject: Re: [PATCH 1/8] dt-bindings: clock: samsung: Add Exynos9610 CMU bindings
Date: Mon, 15 Sep 2025 08:22:01 -0500	[thread overview]
Message-ID: <175794237115.2496914.9134109163312001999.robh@kernel.org> (raw)
In-Reply-To: <20250915-exynos9610-clocks-v1-1-3f615022b178@chimac.ro>


On Sun, 14 Sep 2025 21:19:19 +0000, Alexandru Chimac wrote:
> This clock management unit has a topmost block (CMU_TOP)
> that generates top clocks for other blocks, alongside 20
> other blocks, out of which 11 are currently implemented.
> 
> Signed-off-by: Alexandru Chimac <alex@chimac.ro>
> ---
>  .../bindings/clock/samsung,exynos9610-clock.yaml   | 344 ++++++++++
>  include/dt-bindings/clock/samsung,exynos9610.h     | 720 +++++++++++++++++++++
>  2 files changed, 1064 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml:250:13: [warning] wrong indentation: expected 14 but found 12 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/samsung,exynos9610-clock.yaml: $id: 'http://devicetree.org/schemas/clock/samsung,exynos9610-clock.yaml' does not match 'http://devicetree.org/schemas(/[^/ ]+)+\\.yaml#'
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
Error: Documentation/devicetree/bindings/clock/samsung,exynos9610-clock.example.dts:25.13-14 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/clock/samsung,exynos9610-clock.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1527: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250915-exynos9610-clocks-v1-1-3f615022b178@chimac.ro

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-09-15 13:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-14 21:19 [PATCH 0/8] clk: samsung: Introduce support for Exynos9610 clocks Alexandru Chimac
2025-09-14 21:19 ` [PATCH 1/8] dt-bindings: clock: samsung: Add Exynos9610 CMU bindings Alexandru Chimac
2025-09-15 13:22   ` Rob Herring (Arm) [this message]
2025-09-14 21:19 ` [PATCH 2/8] clk: samsung: clk-pll: Add support for pll_1061x Alexandru Chimac
2025-09-15  4:21   ` Peng Fan
2025-09-14 21:19 ` [PATCH 3/8] clk: samsung: Introduce Exynos9610 clock controller driver Alexandru Chimac
2025-09-14 21:19 ` [PATCH 4/8] arm64: dts: exynos9610: Enable clock support Alexandru Chimac
2025-09-15  4:32   ` Krzysztof Kozlowski
2025-09-14 21:20 ` [PATCH 5/8] dt-bindings: soc: exynos-sysreg: Add Exynos9610 SYSREG bindings Alexandru Chimac
2025-09-15 13:47   ` Rob Herring (Arm)
2025-09-14 21:20 ` [PATCH 6/8] arm64: dts: exynos9610: Add SYSREG nodes Alexandru Chimac
2025-09-14 21:20 ` [PATCH 7/8] arm64: dts: exynos9610: Assign clocks to existing nodes Alexandru Chimac
2025-09-14 21:20 ` [PATCH 8/8] arm64: dts: exynos9610-gta4xl: " Alexandru Chimac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175794237115.2496914.9134109163312001999.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alex@chimac.ro \
    --cc=alexchimac@protonmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox