Re: [PATCH 08/19] clk: divider: check divider validity for CLK_DIVIDER_EVEN_INTEGERS

Benoît Monin
2025-09-25T11:51:42Z

On Saturday, 20 September 2025 at 07:15:45 CEST, Stephen Boyd wrote:
> Quoting Benoît Monin (2025-09-03 05:47:15)
> > Ensure that the divider is even when the flag CLK_DIVIDER_EVEN_INTEGERS
> > is set, similar to the power of two check for CLK_DIVIDER_POWER_OF_TWO.
> >
>
> Is this a fix?
>
This was found during code review, nothing prevents divider_get_val() to
compute an odd divider, but we have not hit a bug caused by that.

Should I add a Fixes tag to
6a136805e3c15 ("clk: divider: IntroduceCLK_DIVIDER_EVEN_INTEGERS flag")
or drop this patch since it does not fix a bug per se?

Best regards,
--
Benoît Monin, Bootlin
Embedded Linux and Kernel engineering