Re: [PATCH 02/19] dt-bindings: clock: mobileye: rename to eyeq-clk.h

Krzysztof Kozlowski
2025-09-04T09:24:25Z

On Wed, Sep 03, 2025 at 02:47:09PM +0200, Benoît Monin wrote:
> Rename the header from mobileye,eyeq5-clk.h to mobileye,eyeq-clk.h as
> it covers more SoCs than just the eyeQ5, but also the eyeQ6L and
> eyeQ6H.
>
> Also changes all includes to point to the renamed header.
>
> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
> ---
> MAINTAINERS | 2 +-
> arch/mips/boot/dts/mobileye/eyeq5.dtsi | 2 +-
> arch/mips/boot/dts/mobileye/eyeq6h.dtsi | 2 +-
> drivers/clk/clk-eyeq.c | 2 +-
> .../dt-bindings/clock/{mobileye,eyeq5-clk.h => mobileye,eyeq-clk.h} | 4 ++--

NAK, stop doing such renames.

Look how other well upstreamed SoCs are doing this - you want file per
SoC variant, so you want SEPARATE eyeq7 header.

Best regards,
Krzysztof