From: Stephen Boyd <sboyd@kernel.org>
To: Alex Elder <elder@riscstar.com>,
Conor Dooley <conor+dt@kernel.org>, Haylen Chu <heylenay@4d2.org>,
Inochi Amaoto <inochiama@outlook.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Yixun Lan <dlan@gentoo.org>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org,
Jinmei Wei <weijinmei@linux.spacemit.com>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>
Subject: Re: [PATCH RESEND v4 3/3] clk: spacemit: fix i2s clock
Date: Fri, 19 Sep 2025 22:55:28 -0700 [thread overview]
Message-ID: <175834772899.4354.17970704155310133154@lazor> (raw)
In-Reply-To: <20250911-k1-clk-i2s-generation-v4-3-cba204a50d48@linux.spacemit.com>
Quoting Troy Mitchell (2025-09-10 20:34:05)
> Defining i2s_bclk and i2s_sysclk as fixed-rate clocks is insufficient
> for real I2S use cases.
>
> Moreover, the current I2S clock configuration does not work as expected
> due to missing parent clocks.
>
> This patch adds the missing parent clocks, defines i2s_sysclk as
> a DDN clock, and i2s_bclk as a DIV clock.
>
> A special note for i2s_bclk:
>
> From the register definition, the i2s_bclk divider always implies
> an additional 1/2 factor.
>
> The following table shows the correspondence between index
> and frequency division coefficients:
>
> | index | div |
> |-------|-------|
Applied to clk-next
prev parent reply other threads:[~2025-09-20 5:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 3:34 [PATCH RESEND v4 0/3] clk: spacemit: fix i2s clock Troy Mitchell
2025-09-11 3:34 ` [PATCH RESEND v4 1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to " Troy Mitchell
2025-09-20 5:55 ` Stephen Boyd
2025-09-11 3:34 ` [PATCH RESEND v4 2/3] clk: spacemit: introduce pre-div for ddn clock Troy Mitchell
2025-09-20 5:55 ` Stephen Boyd
2025-09-11 3:34 ` [PATCH RESEND v4 3/3] clk: spacemit: fix i2s clock Troy Mitchell
2025-09-20 5:55 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175834772899.4354.17970704155310133154@lazor \
--to=sboyd@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=heylenay@4d2.org \
--cc=inochiama@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
--cc=weijinmei@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox