From: "Rob Herring (Arm)" <robh@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
"Stephen Boyd" <sboyd@kernel.org>,
upstream@airoha.com,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
devicetree@vger.kernel.org,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: clock: mediatek: Fix wrong compatible list for hifsys YAML
Date: Tue, 23 Sep 2025 18:15:44 -0500 [thread overview]
Message-ID: <175866934419.400019.15611978179247377029.robh@kernel.org> (raw)
In-Reply-To: <20250923201244.952-2-ansuelsmth@gmail.com>
On Tue, 23 Sep 2025 22:12:29 +0200, Christian Marangi wrote:
> While converting the hifsys to YAML schema, the "syscon" compatible was
> dropped for the mt7623 and the mt2701 compatible.
>
> Add back the compatible to mute DTBs warning on "make dtbs_check" and
> reflect real state of the .dtsi.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> .../devicetree/bindings/clock/mediatek,mt2701-hifsys.yaml | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/mediatek,mt2701-hifsys.example.dtb: clock-controller@1a000000 (mediatek,mt2701-hifsys): compatible: 'oneOf' conditional failed, one must be fixed:
['mediatek,mt2701-hifsys'] is too short
'mediatek,mt7622-hifsys' was expected
'mediatek,mt2701-hifsys' is not one of ['mediatek,mt7623-hifsys']
from schema $id: http://devicetree.org/schemas/clock/mediatek,mt2701-hifsys.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250923201244.952-2-ansuelsmth@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-09-23 23:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 20:12 [PATCH v2 0/4] PCI: mediatek: add support AN7583 + YAML rework Christian Marangi
2025-09-23 20:12 ` [PATCH v2 1/4] dt-bindings: clock: mediatek: Fix wrong compatible list for hifsys YAML Christian Marangi
2025-09-23 23:15 ` Rob Herring (Arm) [this message]
2025-09-24 14:03 ` Rob Herring
2025-09-25 16:06 ` Christian Marangi
2025-09-23 20:12 ` [PATCH v2 2/4] dt-bindings: PCI: mediatek: Convert to YAML schema Christian Marangi
2025-09-23 20:12 ` [PATCH v2 3/4] dt-bindings: PCI: mediatek: Add support for Airoha AN7583 Christian Marangi
2025-09-23 20:12 ` [PATCH v2 4/4] PCI: mediatek: add support for Airoha AN7583 SoC Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175866934419.400019.15611978179247377029.robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=ryder.lee@mediatek.com \
--cc=sboyd@kernel.org \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox