From: "Rob Herring (Arm)" <robh@kernel.org>
To: Matti Vaittinen <matti.vaittinen@linux.dev>
Cc: Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Andreas Kemnade <andreas@kemnade.info>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Stephen Boyd <sboyd@kernel.org>, Pavel Machek <pavel@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-gpio@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, linux-leds@vger.kernel.org,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-rtc@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v3 01/16] dt-bindings: regulator: ROHM BD72720
Date: Wed, 05 Nov 2025 03:00:12 -0600 [thread overview]
Message-ID: <176233320981.143013.4115240062372455834.robh@kernel.org> (raw)
In-Reply-To: <48fe6e2642db4484640b173cd71be1b245929122.1762327887.git.mazziesaccount@gmail.com>
On Wed, 05 Nov 2025 09:35:59 +0200, Matti Vaittinen wrote:
> From: Matti Vaittinen <mazziesaccount@gmail.com>
>
> The ROHM BD72720 is a new PMIC with 10 BUCk and 11 LDO regulators.
>
> The BD72720 is designed to support using the BUCK10 as a supply for
> the LDOs 1 to 4. When the BUCK10 is used for this, it can be set to a
> LDON_HEAD mode. In this mode, the BUCK10 voltage can't be controlled by
> software, but the voltage is adjusted by PMIC to match the LDO1 .. LDO4
> voltages with a given offset. Offset can be 50mV .. 300mV and is
> changeable at 50mV steps.
>
> Add 'ldon-head-microvolt' property to denote a board which is designed
> to utilize the LDON_HEAD mode.
>
> All other properties are already existing.
>
> Add dt-binding doc for ROHM BD72720 regulators to make it usable.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
>
> ---
> Revision history:
> v2 => v3:
> - drop unnecessary descriptions
> - use microvolts for the 'ldon-head' dt-property
>
> RFCv1 => v2:
> - No changes
> ---
> .../regulator/rohm,bd72720-regulator.yaml | 149 ++++++++++++++++++
> 1 file changed, 149 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml: patternProperties:^buck[1-10]$:properties:rohm,ldon-head-microvolt: '$ref' should not be valid under {'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml
doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml
Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml: Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/48fe6e2642db4484640b173cd71be1b245929122.1762327887.git.mazziesaccount@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-11-05 9:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 7:34 [PATCH v3 00/16] Support ROHM BD72720 PMIC Matti Vaittinen
2025-11-05 7:35 ` [PATCH v3 01/16] dt-bindings: regulator: ROHM BD72720 Matti Vaittinen
2025-11-05 9:00 ` Rob Herring (Arm) [this message]
2025-11-05 11:22 ` Matti Vaittinen
2025-11-05 7:36 ` [PATCH v3 02/16] dt-bindings: battery: Clarify trickle-charge Matti Vaittinen
2025-11-06 8:00 ` Krzysztof Kozlowski
2025-11-10 23:04 ` Linus Walleij
2025-11-05 7:36 ` [PATCH v3 03/16] dt-bindings: battery: Add trickle-charge upper limit Matti Vaittinen
2025-11-06 8:01 ` Krzysztof Kozlowski
2025-11-05 7:36 ` [PATCH v3 04/16] dt-bindings: power: supply: BD72720 managed battery Matti Vaittinen
2025-11-05 9:00 ` Rob Herring (Arm)
2025-11-05 7:37 ` [PATCH v3 05/16] dt-bindings: mfd: ROHM BD72720 Matti Vaittinen
2025-11-05 9:00 ` Rob Herring (Arm)
2025-11-05 11:39 ` Matti Vaittinen
2025-11-05 7:37 ` [PATCH v3 06/16] dt-bindings: leds: bd72720: Add BD72720 Matti Vaittinen
2025-11-05 7:37 ` [PATCH v3 07/16] mfd: rohm-bd71828: Use regmap_reg_range() Matti Vaittinen
2025-11-05 7:37 ` [PATCH v3 08/16] mfd: bd71828: Support ROHM BD72720 Matti Vaittinen
2025-11-05 7:38 ` [PATCH v3 09/16] regulator: bd71828: rename IC specific entities Matti Vaittinen
2025-11-05 7:38 ` [PATCH v3 10/16] regulator: bd71828: Support ROHM BD72720 Matti Vaittinen
2025-11-05 7:38 ` [PATCH v3 11/16] gpio: Support ROHM BD72720 gpios Matti Vaittinen
2025-11-05 7:39 ` [PATCH v3 12/16] clk: clk-bd718x7: Support BD72720 clk gate Matti Vaittinen
2025-11-05 7:39 ` [PATCH v3 13/16] rtc: bd70528: Support BD72720 rtc Matti Vaittinen
2025-11-05 7:39 ` [PATCH v3 14/16] power: supply: bd71828: Support wider register addresses Matti Vaittinen
2025-11-05 7:39 ` [PATCH v3 15/16] power: supply: bd71828-power: Support ROHM BD72720 Matti Vaittinen
2025-11-05 7:40 ` [PATCH v3 16/16] MAINTAINERS: Add ROHM BD72720 PMIC Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176233320981.143013.4115240062372455834.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andreas@kemnade.info \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=matti.vaittinen@linux.dev \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox