From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <laurent.pinchart@ideasonboard.com>
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: r8a7795: salvator-x: Add DU0 and DU3 external dot clocks
Date: Thu, 12 Jan 2017 03:48:27 +0200
Message-ID: <1877425.MQhPRHFZli@avalon>
In-Reply-To: <537b6144-cdc1-a840-a41a-aa99b6b7a20b@gmail.com>
References: <20170111161603.18905-2-marek.vasut@gmail.com> <20170112005330.8094-1-laurent.pinchart+renesas@ideasonboard.com> <537b6144-cdc1-a840-a41a-aa99b6b7a20b@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
List-ID: <linux-clk.vger.kernel.org>

Hi Marek,

On Thursday 12 Jan 2017 01:57:09 Marek Vasut wrote:
> On 01/12/2017 01:53 AM, Laurent Pinchart wrote:
> > The clocks are generated by an I2C-controlled programmable clock
> > generator.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 29 +++++++++++++++--
> >  1 file changed, 27 insertions(+), 2 deletions(-)
> > 
> > Hi Marek,
> > 
> > With this patch applied on top of a merge of my HDMI output series and
> > your VC5 series, I've successfully tested VGA output and LVDS output on
> > the Salvator-X H3 board. You can thus add
> > 
> > Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Thanks!
> 
> Minor nit below :)
> 
> > to patch 2/2.
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts index
> > 2dc0887fc400..22be583be4bc 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > @@ -178,6 +178,12 @@
> >  		clock-frequency = <33000000>;
> >  	};
> > 
> > +	x23_clk: x23-clock {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <25000000>;
> > +	};
> > +
> >  	hdmi0-out {
> >  		compatible = "hdmi-connector";
> >  		label = "HDMI0 OUT";
> > @@ -271,10 +277,15 @@
> >  		 <&cpg CPG_MOD 722>,
> >  		 <&cpg CPG_MOD 721>,
> >  		 <&cpg CPG_MOD 727>,
> > +		 <&versaclock5 1>,
> >  		 <&x21_clk>,
> > -		 <&x22_clk>;
> > +		 <&x22_clk>,
> > +		 <&versaclock5 2>;
> > 
> >  	clock-names = "du.0", "du.1", "du.2", "du.3", "lvds.0",
> > -		      "dclkin.1", "dclkin.2";
> > +		      "dclkin.0", "dclkin.1", "dclkin.2", "dclkin.3";
> > +
> > +	assigned-clocks = <&versaclock5 1>, <&versaclock5 2>;
> > +	assigned-clock-rates = <148500000>, <108000000>;
> 
> I think you want to remove these two lines ^^^^^^^^^

You're right. I've tested the patch with those two lines removed, and things 
still work fine. I'll resubmit.

-- 
Regards,

Laurent Pinchart