From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Geert Uytterhoeven Cc: Magnus Damm , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Magnus Damm , Simon Horman , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-clk , "devicetree@vger.kernel.org" , Linux-sh list Subject: Re: [PATCH v4 1/5] [RFC] clk: shmobile: Add new Renesas CPG/MSSR DT bindings Date: Fri, 23 Oct 2015 14:11:41 +0300 Message-ID: <19544825.jsyW3b77En@avalon> In-Reply-To: References: <1444999760-15750-1-git-send-email-geert+renesas@glider.be> <1832656.BCXoHFFChX@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" List-ID: Hi Geert, On Friday 23 October 2015 13:09:22 Geert Uytterhoeven wrote: > On Fri, Oct 23, 2015 at 1:05 PM, Laurent Pinchart wrote: > > On Wednesday 21 October 2015 01:01:03 Magnus Damm wrote: > >> On Tue, Oct 20, 2015 at 9:16 PM, Geert Uytterhoeven wrote: > >>> On Fri, Oct 16, 2015 at 2:49 PM, Geert Uytterhoeven wrote: > >>>> --- /dev/null > >>>> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt > >>>> @@ -0,0 +1,71 @@ > >>>> +* Renesas Clock Pulse Generator / Module Standby and Software Reset > >>>> + > >>>> +On Renesas ARM SoCs (SH/R-Mobile, R-Car, RZ), the CPG (Clock Pulse > >>>> Generator) > >>>> +and MSSR (Module Standby and Software Reset) blocks are intimately > >>>> connected, > >>>> +and share the same register block. > >>>> + > >>>> +They provide the following functionalities: > >>>> + - The CPG block generates various core clocks, > >>>> + - The MSSR block provides two functions: > >>>> + 1. Module Standby, providing a Clock Domain to control the > >>>> clock supply > >>>> + to individual SoC devices, > >>>> + 2. Reset Control, to perform a software reset of individual SoC > >>>> devices. > >>>> + > >>>> +Required Properties: > >>>> + - compatible: Must be one of: > >>>> + - "renesas,r8a7791-cpg-mssr" for the r8a7791 SoC > >>> > >>> I'll drop the reference to "r8a7791", as we won't convert r8a7791 > >>> (yet). > > > > I'm fine with supporting r8a7795 only in the initial patch set, but when > > do we plan to convert r8a7791 ? I think it would be a good idea to > > validate these > > That's a political question... > > > bindings on r8a7791 before considering them as stable. > > I did the validation on both r8a7795/salvator-x and r8a7791/koelsch. > Please try branch topic/cpg-mssr-v4 of renesas-drivers. If it works what's blocking r8a7791 support from being upstreamed ? :-) -- Regards, Laurent Pinchart