Re: [PATCH 1/3] dt-bindings: clock: Add Qualcomm SC8180X Camera clock controller

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 4/26/25 4:03 PM, Vladimir Zapolskiy wrote:
> On 4/22/25 08:42, Satya Priya Kakitapalli wrote:
>> Add device tree bindings for the camera clock controller on
>> Qualcomm SC8180X platform.
>>
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>>   .../bindings/clock/qcom,sc8180x-camcc.yaml         |  65 ++++++++
>>   include/dt-bindings/clock/qcom,sc8180x-camcc.h     | 181 +++++++++++++++++++++
>>   2 files changed, 246 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc8180x-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc8180x-camcc.yaml
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..b17f40ee53a3002b2942869d60773dbecd764134
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sc8180x-camcc.yaml
>> @@ -0,0 +1,65 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,sc8180x-camcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Camera Clock & Reset Controller on SC8180X
>> +
>> +maintainers:
>> +  - Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> +
>> +description: |
>> +  Qualcomm camera clock control module provides the clocks, resets and
>> +  power domains on SC8180X.
>> +
>> +  See also: include/dt-bindings/clock/qcom,sc8180x-camcc.h
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,sc8180x-camcc
>> +
>> +  clocks:
>> +    items:
>> +      - description: Board XO source
> 
> From sc8180x_rpmh_clocks[] in clk/qcom/clk-rpmh.c I get that there is
> RPMH_CXO_CLK_A clock also, shall it be added to this list then?

_AO only makes sense for CPU-XYZ clocks which (almost?) exclusively reside
in gcc, and most of the time they aren't even necessary to describe in Linux

I'm not sure there's anything in CAM_CC that would benefit from it

XO_A is in the end the same physical clock as XO (or at least used to be)
except it places a vote in RPMh such that the harwdare takes care of gating
it upon cpuss suspend entry


> 
> If yes, and taking into account Konrad's ask for GCC_CAMERA_AHB_CLK, it
> implies that the new dt bindings can be omitted, instead please consider
> to add the 'qcom,sc8180x-camcc' compatible into qcom,sa8775p-camcc.yaml.
> 
> However still there is a difference, qcom,sa8775p-camcc and qcom,qcs8300-camcc
> does not contain 'required-opps' property, it might be an omission over
> there though, please double check it. The ultimate goal would be to get
> a shorter list of different camcc dt bindings.


for required-opps see:

https://lore.kernel.org/linux-arm-msm/44dad3b5-ea3d-47db-8aca-8f67294fced9@quicinc.com/

Konrad