public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Bo Gan <ganboing@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: samuel.holland@sifive.com, emil.renner.berthing@canonical.com,
	mturquette@baylibre.com, paul.walmsley@sifive.com
Subject: Re: [PATCH] clk: analogbits: Fix incorrect calculation of vco rate delta
Date: Wed, 28 Aug 2024 14:23:37 -0700	[thread overview]
Message-ID: <1b245182-09db-44a1-bdee-3ec0658bef47@gmail.com> (raw)
In-Reply-To: <ad33e8561ca236c5f897003fb40bdc09.sboyd@kernel.org>

On 8/28/24 11:52, Stephen Boyd wrote:
> Quoting Bo Gan (2024-08-26 23:19:54)
>> In function `wrpll_configure_for_rate`, we try to determine the best PLL
>> configuration for a target rate. However, in the loop where we try values
>> of R, we should compare the derived `vco` with `target_vco_rate`. However,
>> we were in fact comparing it with `target_rate`, which is actually after
>> Q shift. This is incorrect, and sometimes can result in suboptimal clock
>> rates. This patch fixes it.
>>
>> Signed-off-by: Bo Gan <ganboing@gmail.com>
>> ---
> 
> Please add a Fixes tag.
> 
> Also, your patch has tons of diff context. Why?

Hi Stephen,

Thanks for the reply. I'll add the Fixes tag in v2. I explicitly enlarged the
diff to show more surrounding contexts for better readability. Any other issue
I should fix?

Bo

  reply	other threads:[~2024-08-28 21:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27  6:19 [PATCH] clk: analogbits: Fix incorrect calculation of vco rate delta Bo Gan
2024-08-28 18:52 ` Stephen Boyd
2024-08-28 21:23   ` Bo Gan [this message]
2024-08-28 22:38     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b245182-09db-44a1-bdee-3ec0658bef47@gmail.com \
    --to=ganboing@gmail.com \
    --cc=emil.renner.berthing@canonical.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=paul.walmsley@sifive.com \
    --cc=samuel.holland@sifive.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox