Re: [PATCH v4 3/6] dt-bindings: drm/msm/gpu: Document AON clock for A505/A506/A510

Krzysztof Kozlowski
2025-03-17T09:21:53Z

On Sat, Mar 15, 2025 at 03:57:37PM +0100, Barnabás Czémán wrote:
> From: Adam Skladowski <a39.skl@gmail.com>
>
> Adreno 505 (MSM8937), Adreno 506(MSM8953) and Adreno 510(MSM8976)
> require Always-on branch clock to be enabled, describe it.
>
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> [reword commit, move alwayson on the first place]
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
> Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> index 6ddc72fd85b04537ea270754a897b4e7eb269641..5028398cc3b517e404a92a2c30688f72eab4c1b3 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> @@ -152,11 +152,13 @@ allOf:
> properties:
> clocks:
> minItems: 2
> - maxItems: 7
> + maxItems: 8
>
> clock-names:
> items:
> anyOf:
> + - const: alwayson
> + description: GPU Always-On clock

Are you adding bindings for devices which were not described previously?
Then don't grow this pattern, but create if:then: with a strictly
ordered list for them (and keeping order of other variants).

Best regards,
Krzysztof