From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 124EEC4167D for ; Fri, 3 Nov 2023 17:51:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229450AbjKCRvv (ORCPT ); Fri, 3 Nov 2023 13:51:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbjKCRvu (ORCPT ); Fri, 3 Nov 2023 13:51:50 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1B1A1D42; Fri, 3 Nov 2023 10:51:47 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 77F962F4; Fri, 3 Nov 2023 10:52:29 -0700 (PDT) Received: from [10.57.81.32] (unknown [10.57.81.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7D4DC3F738; Fri, 3 Nov 2023 10:51:41 -0700 (PDT) Message-ID: <1cbc6def-8255-4a13-99b0-145d3f8ffcac@arm.com> Date: Fri, 3 Nov 2023 17:51:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 08/10] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform Content-Language: en-GB To: =?UTF-8?Q?Duje_Mihanovi=C4=87?= , Michael Turquette , Stephen Boyd , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tony Lindgren , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Leo Yan , Zhangfei Gao , Lubomir Rintel , Catalin Marinas , Will Deacon , Kees Cook , Tony Luck , "Guilherme G . Piccoli" Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Karel Balej References: <20231102152033.5511-1-duje.mihanovic@skole.hr> <20231102152033.5511-3-duje.mihanovic@skole.hr> <2919185.e9J7NaK4W3@radijator> From: Robin Murphy In-Reply-To: <2919185.e9J7NaK4W3@radijator> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 2023-11-03 5:02 pm, Duje Mihanović wrote: > On Friday, November 3, 2023 4:34:54 PM CET Robin Murphy wrote: >> On 2023-11-02 3:20 pm, Duje Mihanović wrote: >>> +config ARCH_MMP >>> + bool "Marvell MMP SoC Family" >>> + select ARM_GIC >>> + select ARM_ARCH_TIMER >>> + select ARM_SMMU >> >> NAK, not only is selecting user-visible symbols generally frowned upon, >> and ignoring their dependencies even worse, but for a multiplatform >> kernel the user may well want this to be a module. >> >> If having the SMMU driver built-in is somehow fundamentally required for >> this platform to boot, that would represent much bigger problems. > > The SoC can boot without SMMU and PDMA, but not GIC, pinctrl or the arch > timer. I see that most other SoCs still select drivers and frameworks they > presumably need for booting, with the exceptions of ARCH_BITMAIN, ARCH_LG1K > and a couple others. Which of these two options should I go for? Well, you don't really need to select ARM_GIC or ARM_ARCH_TIMER here either, since those are already selected by ARM64 itself. Keeping PINCTRL_SINGLE is fair, although you should also select PINCTRL as its dependency. As an additional nit, the file seems to be primarily ordered by symbol name, so it might be nice to slip ARCH_MMC in between ARCH_MESON and ARCH_MVEBU. Cheers, Robin.