From: Stephen Boyd <sboyd@kernel.org>
To: Yuesong Li <liyuesong@vivo.com>,
abelvesa@kernel.org, mturquette@baylibre.com,
s.hauer@pengutronix.de, shawnguo@kernel.org
Cc: peng.fan@nxp.com, kernel@pengutronix.de, festevam@gmail.com,
shengjiu.wang@nxp.com, linux-clk@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com,
Yuesong Li <liyuesong@vivo.com>
Subject: Re: [PATCH v1] clk:clk-imx8-acm:fix wrong pointer check in clk_imx_acm_attach_pm_domains()
Date: Tue, 20 Aug 2024 15:07:22 -0700 [thread overview]
Message-ID: <1d4c39e109bcf288d5900670e024a315.sboyd@kernel.org> (raw)
In-Reply-To: <20240820025902.2355565-1-liyuesong@vivo.com>
Quoting Yuesong Li (2024-08-19 19:59:02)
> device_link_add() returns NULL pointer not PTR_ERR() when it fails,so
> replace the IS_ERR() check with NULL pointer check.
Can you document that fact by adding a "Return:" line to the kernel-doc
for device_link_add() in another patch?
prev parent reply other threads:[~2024-08-20 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 2:59 [PATCH v1] clk:clk-imx8-acm:fix wrong pointer check in clk_imx_acm_attach_pm_domains() Yuesong Li
2024-08-20 22:07 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d4c39e109bcf288d5900670e024a315.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=abelvesa@kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liyuesong@vivo.com \
--cc=mturquette@baylibre.com \
--cc=opensource.kernel@vivo.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).