From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A174A1A0732 for ; Thu, 28 Nov 2024 13:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732800804; cv=none; b=um5Bogn61wg0iCpje6t0BykA4nKv1NNkTxPIlkBz2qtr1qSe+gBANix7lacI+05Ek7ygI1lobAoecIxmQ2JgP87/ApnB3tefvCyZYN6Ydfsc9iM9+64ZY9Oq0kU/Zf7kAGF/4VrOd0uQL0J2BKKMRDLyHtz43loqL85/ALs3BGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732800804; c=relaxed/simple; bh=PjLyi71hJ+wl65ox0a4Xn1LoN5tr4uIfT5gZ+kJDbBQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=knOi7l+qSKjqt0jVRn2/10FYOqqBjJmqwSd4+0DDT4mSvREngnQQmoUFpFeiTV+9Nd2g6wGqoSHoFr4nD9t0g2OwT9Rxa3qnb/NWLJkycfBoQ3JLPmB1Xi2XOvj35KgblsCPgeb7+4kKpkpDLRf5mWGGmUX7nwC/Re1/eXtIkj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=SdW4dOF0; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="SdW4dOF0" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-434acf1f9abso7434065e9.2 for ; Thu, 28 Nov 2024 05:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1732800800; x=1733405600; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=gmgFSpEV/joPPiUmtOBENMot4M1WgXF/FvOd2XyYmN4=; b=SdW4dOF0KGtcZSilfPOngLu3gu7WMh+deQUQZ6Xo9ezysvjQDtUZ/87cf7Rs84b2lK HIVd0P2Zar94M7rdaW38YwQTIYFLBXLZxwgxpGtC5a3tXKZBS+KtDrFmbtqm6nT/l0Mx d1JO8xt5Bh+5a1A0dgk8ncnGCBUILydG4mdIL6EHW/z4R67iWZHJtnjsOEpiswI2B/zK ++0F7Vd9mrPKQZ58qXEC5DQkS5o1P+23TtxQXTWas0TVC40XKUMKLiiTIAwt881LDw6L YuNX6qFdVD8aOxj9jc1Sca76/ofDYjaMmwm2iiw/Anc6LlfJ+4LLK8REoregG6wCLJM7 cyrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732800800; x=1733405600; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gmgFSpEV/joPPiUmtOBENMot4M1WgXF/FvOd2XyYmN4=; b=fDeXPPoqCthJx8fCZ66BzsgdrMv5/G0D3lPNvq5UkeC9j8cwYJqHDYsECOkUsJuXg3 RsyfFq4aV0ioRskqkdIb5Ik7WxrddBCawcQVv1VN+hoDexQprEfl0Bst29Edmt+YYxqV Q5d3TFH6rquQYP4RM2+ZrTsFQOjb0hFfzaYAorGJatYhMBFEeKm2PUO5JQ0nGx64lalj Fvh3DUy5NDw4sOdPJEuG8LblzLJ4+B5N39GocBYOVhM+7SsioUEcRZI38w5d4zV4ZYd3 sRy7Ml6bBiKd2RH27jW4XX1zGs8LosFkegh3E4W8lMn/OJjb8I1ERpYr0mqEeSsYh/1i JvGA== X-Forwarded-Encrypted: i=1; AJvYcCV157w+dWKTdgHJuuIN3qmhljIjUsx8sZ6+fyyKPXslMxj4e83B9nSeV6DpKkk//FUKN2n824n/gHM=@vger.kernel.org X-Gm-Message-State: AOJu0YzpELuFC/4x4xOsZ/Uv9yyAmu0wL6p8CpQc/YD9coixGLbC8zpD 1eeCfQY8QGa6qDPZdvT0bsR3wwtcPemX1DdA330qJBlaGrGsyyOo7HrCqOszmZc= X-Gm-Gg: ASbGncuGo0OZPBrPznqKJpYbKPPaC3DkuLZBCoHjvdLVZ6tCxmuVWxLiXQdnEjZ8p2e ukMgCuEh4Qlzng8+VStnBzYoGvuAUwVfyZZfBryhagzi5TcILL07uQp1VFbCpS5i4NhcRpylJV4 q8UwdE0JX9Fq4fG7dMVOaxk3QqD+tDpLZN2tya2pDXwXbTHiU5hno598Ga60CUk94NCueWfnIEU Tos5YL05atZJoPT9+DKTuGgGCBiMH6DjncMgT50pjONarsMJg== X-Google-Smtp-Source: AGHT+IGrMdn+38U9uolOFNk+mS2Fm4W0jJARLcSQoHOhr2LuU6616dbNhFwztnrfvkaZnx6NZ9uZrw== X-Received: by 2002:a05:600c:1d8d:b0:434:a902:4168 with SMTP id 5b1f17b1804b1-434a9dd00d3mr68710925e9.18.1732800799856; Thu, 28 Nov 2024 05:33:19 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:b89d:29e9:7047:2d6f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0d9bee2sm22577455e9.1.2024.11.28.05.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 05:33:19 -0800 (PST) From: Jerome Brunet To: "Arnd Bergmann" Cc: "Neil Armstrong" , "Michael Turquette" , "Stephen Boyd" , "Kevin Hilman" , "Martin Blumenstingl" , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Mark Brown" Subject: Re: [PATCH] clk: amlogic: axg-audio: select RESET_MESON_AUX In-Reply-To: (Arnd Bergmann's message of "Wed, 27 Nov 2024 22:23:52 +0100") References: <20241127-clk-audio-fix-rst-missing-v1-1-9f9d0ab98fce@baylibre.com> <12f29978-c8ce-4bee-a447-dcd086eb936d@app.fastmail.com> <1ja5dk2y5l.fsf@starbuckisacylon.baylibre.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Thu, 28 Nov 2024 14:33:18 +0100 Message-ID: <1j4j3r32ld.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed 27 Nov 2024 at 22:23, "Arnd Bergmann" wrote: > On Wed, Nov 27, 2024, at 21:56, Jerome Brunet wrote: >> On Wed 27 Nov 2024 at 20:30, "Arnd Bergmann" wrote: >>> >>> It looks like RESET_MESON_AUX is a user-visible symbol, >>> so you can simply ask users to turn it on, and add it to >>> the defconfig. >> >> That would work yes but It's really something a user should not be >> concerned with. I can follow-up with another change to remove the user >> visibilty of RESET_MESON_AUX. It is always going to be something >> requested by another driver. > > But that's true for all reset drivers, each one of them is > only useful because it's going to be used by another driver, > same for clk, pinctrl, regulator, ... > All clk, pinctrl or regulator are used by other driver yes, this one as well, sure. What special about this on is that it is an auxiliary bus driver. It is directly instantiated by another driver. That's where it differs. The axg-audio clock driver instantiate the auxiliary reset, it does not use it, which is why it makes sense for it to select the driver. I agree that in such case I should not have added prompt for that symbol. I'd be happy to fix that mistake in the coming cycle. > All other reset drivers are user-visible, with 'default, so for > consistency I think it's best to keep it that way, and > just add a 'default ARCH_MESON' the same way we have for many > other reset drivers: Same consistency remark applies to the clock Kconfig patched here, which select the drivers they directly need and I'd like to keep consistency here too. Also 'default ARCH_MESON' does not accurately reflect when the driver is needed, it will turn on the driver in configuration where it is not necessarily needed, making it more difficult to trim the configuration down without intimate knowledge of the problem. ATM, RESET_MESON_AUX is only needed if COMMON_CLK_AXG_AUDIO is enabled. Isn't it what select is all about ? > > diff --git a/drivers/reset/amlogic/Kconfig b/drivers/reset/amlogic/Kconfig > index 3bee9fd60269..c02edc1b51aa 100644 > --- a/drivers/reset/amlogic/Kconfig > +++ b/drivers/reset/amlogic/Kconfig > @@ -14,6 +14,7 @@ config RESET_MESON > config RESET_MESON_AUX > tristate "Meson Reset Auxiliary Driver" > depends on ARCH_MESON || COMPILE_TEST > + default ARCH_MESON > select AUXILIARY_BUS > select RESET_MESON_COMMON > help > > The only bit that's special here is the exported symbol, > but that is handled by the dependency. > >>> I also see some silliness going on in the >>> include/soc/amlogic/reset-meson-aux.h, which has a >>> non-working 'static inline' definition of the exported >>> function. Before my fix, that would have caused the >>> problem auf a non-working audio driver. >> >> If by 'silliness' you mean there is symbol definition for when >> RESET_MESON_AUX is disabled, indeed I guess that could go away. > > Yes, that's what I meant. > > Arnd -- Jerome