From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D99BC0650E for ; Wed, 3 Jul 2019 14:17:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F43B21881 for ; Wed, 3 Jul 2019 14:17:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="Q0TBA8sK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726811AbfGCORN (ORCPT ); Wed, 3 Jul 2019 10:17:13 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55306 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725847AbfGCORN (ORCPT ); Wed, 3 Jul 2019 10:17:13 -0400 Received: by mail-wm1-f65.google.com with SMTP id a15so2399396wmj.5 for ; Wed, 03 Jul 2019 07:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=ks0bNwYapiN81vVxECStRbRSKzS0XfjKhzZiJiwEzwY=; b=Q0TBA8sKjhi4NK59C7tFimG/AiuJj8NjmNS77iU+k2Qmfdlh5Dc/rYAbcd/fDqSnHD /tbji06th9Xzvmi6KQ0uXit+8krhr5CAYIpig2H0xEGI/LCLsktoZD3PYI6Rn/QrD1qM vbLjZExZoQKayF3xaOkXoR9FF0/sx79SNWx9MGV3qQwP/4bgQ9YKmScXh2ZUf9m/vYCp huQ4lLrwpG3T5OrkuEDapgp3jUknzjOiRfKo+KCjpTWTDed2O9fYTFZEDa5/fZz+rHzD xRLlKBOUC1tD63wpfzRqC4OVCVX6I3q7Q37ZfKRvMIJ+fzmou0ZnLyEUXul4j+0JhFgW xtQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=ks0bNwYapiN81vVxECStRbRSKzS0XfjKhzZiJiwEzwY=; b=N60A/O0dr9EJuEHTmi/xVq0/1uc26pRD8XifLTQxXPWpAnr3fH5XLitWEzOyZTYGLK /OxXzAW2/w12w8PtyRGwtxQpVha//x5jJ2U/kfCInE2ZuiMJvhkZx0NZ5ztz1xz5/i9T oTL8u34GpVFaAOL/QqhRwxs2qQwauYn90TfKzyENZkcM0jQnV6YpU4jAbjnTWfQ/h5r5 2eefGr1/R7b8izXietD8vOacArM1r4YpHwtrUMb8mp2Hq8FAGFFVKV7fSqDTK95fTANy MdGZ5eRHpHD0t4eZHvWoA7zouFmiqjDSVdxrFOcLldHsh4KpSXw0OP5xKkZkC4tD3imb L/5A== X-Gm-Message-State: APjAAAUObLCH4kci1d/ZCgh4md843eFDOVLIFWQaZPuK2Pi5oMxOSJMP hftg60NSlkGnnQs55dBCxdYmZA== X-Google-Smtp-Source: APXvYqxmeARZ+dzcLmNlaBGXg9WvX8W+EC2+HrDQkCGX+smg1Bl3ozbQengqGYQ1JBWeO/R5WhX85A== X-Received: by 2002:a05:600c:21d4:: with SMTP id x20mr7439597wmj.61.1562163431645; Wed, 03 Jul 2019 07:17:11 -0700 (PDT) Received: from localhost (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id x83sm2813879wmb.42.2019.07.03.07.17.10 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Jul 2019 07:17:11 -0700 (PDT) From: Jerome Brunet To: Neil Armstrong , khilman@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, martin.blumenstingl@googlemail.com, linux-gpio@vger.kernel.org, Neil Armstrong Subject: Re: [RFC/RFT v3 04/14] clk: meson: eeclk: add setup callback In-Reply-To: <20190701091258.3870-5-narmstrong@baylibre.com> References: <20190701091258.3870-1-narmstrong@baylibre.com> <20190701091258.3870-5-narmstrong@baylibre.com> Date: Wed, 03 Jul 2019 16:17:10 +0200 Message-ID: <1jh8836w49.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Mon 01 Jul 2019 at 11:12, Neil Armstrong wrote: > Add a setup() callback in the eeclk structure, to call an optional > call() function at end of eeclk probe to setup clocks. > > It's used for the G12A clock controller to setup the CPU clock > notifiers. I'd prefer if you implement the probe function in the related controller have this probe function call meson_eeclkc_probe() for the common part In your case, I suppose it means implementing the g12a controller probe to deal with the notifiers > > Signed-off-by: Neil Armstrong > --- > drivers/clk/meson/meson-eeclk.c | 6 ++++++ > drivers/clk/meson/meson-eeclk.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/drivers/clk/meson/meson-eeclk.c b/drivers/clk/meson/meson-eeclk.c > index 6ba2094be257..81fd2abcd173 100644 > --- a/drivers/clk/meson/meson-eeclk.c > +++ b/drivers/clk/meson/meson-eeclk.c > @@ -61,6 +61,12 @@ int meson_eeclkc_probe(struct platform_device *pdev) > } > } > > + if (data->setup) { > + ret = data->setup(pdev); > + if (ret) > + return ret; > + } > + > return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, > data->hw_onecell_data); > } > diff --git a/drivers/clk/meson/meson-eeclk.h b/drivers/clk/meson/meson-eeclk.h > index 9ab5d6fa7ccb..7fdf424f71a6 100644 > --- a/drivers/clk/meson/meson-eeclk.h > +++ b/drivers/clk/meson/meson-eeclk.h > @@ -20,6 +20,7 @@ struct meson_eeclkc_data { > const struct reg_sequence *init_regs; > unsigned int init_count; > struct clk_hw_onecell_data *hw_onecell_data; > + int (*setup)(struct platform_device *pdev); > }; > > int meson_eeclkc_probe(struct platform_device *pdev); > -- > 2.21.0