Re: [PATCH v1 08/11] clk: move meson clk-regmap implementation to common code

Neil Armstrong
2024-10-02T11:20:47Z

On 02/10/2024 12:48, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> I like this one better than qualcomms and wish to use it for the
> PolarFire SoC clock drivers.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> drivers/clk/Kconfig | 4 ++
> drivers/clk/Makefile | 1 +
> drivers/clk/{meson => }/clk-regmap.c | 2 +-
> drivers/clk/meson/Kconfig | 46 +++++++++----------
> drivers/clk/meson/Makefile | 1 -
> drivers/clk/meson/a1-peripherals.c | 2 +-
> drivers/clk/meson/a1-pll.c | 2 +-
> drivers/clk/meson/axg-aoclk.c | 2 +-
> drivers/clk/meson/axg-audio.c | 2 +-
> drivers/clk/meson/axg.c | 2 +-
> drivers/clk/meson/c3-peripherals.c | 2 +-
> drivers/clk/meson/c3-pll.c | 2 +-
> drivers/clk/meson/clk-cpu-dyndiv.c | 2 +-
> drivers/clk/meson/clk-dualdiv.c | 2 +-
> drivers/clk/meson/clk-mpll.c | 2 +-
> drivers/clk/meson/clk-phase.c | 2 +-
> drivers/clk/meson/clk-pll.c | 2 +-
> drivers/clk/meson/g12a-aoclk.c | 2 +-
> drivers/clk/meson/g12a.c | 2 +-
> drivers/clk/meson/gxbb-aoclk.c | 2 +-
> drivers/clk/meson/gxbb.c | 2 +-
> drivers/clk/meson/meson-aoclk.h | 2 +-
> drivers/clk/meson/meson-eeclk.c | 2 +-
> drivers/clk/meson/meson-eeclk.h | 2 +-
> drivers/clk/meson/meson8-ddr.c | 2 +-
> drivers/clk/meson/meson8b.c | 2 +-
> drivers/clk/meson/s4-peripherals.c | 2 +-
> drivers/clk/meson/s4-pll.c | 2 +-
> drivers/clk/meson/sclk-div.c | 2 +-
> drivers/clk/meson/vclk.h | 2 +-
> drivers/clk/meson/vid-pll-div.c | 2 +-
> .../meson => include/linux/clk}/clk-regmap.h | 0
> 32 files changed, 53 insertions(+), 53 deletions(-)
> rename drivers/clk/{meson => }/clk-regmap.c (99%)
> rename {drivers/clk/meson => include/linux/clk}/clk-regmap.h (100%)
>
<snip>

I don't have objections, but I think Stephen didn't like the idea
a few years ago, but perhaps it has changed...

Anyway, take my:
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil